See nsInstallProgressDialog::GetCancelStatus(PRBool *_retval).

moving to m10

Setting Priority and Serverity per Jan's email.

Polling the dialog is probably not the way we want to do it, thus we would remove this function entirely. One alternative is to implement an nsIDOMDocumentObserver to call us when something has changed (but it might call us everytime *we* changed the dlg, which would be bad!), or pass in our own interface purely for use by the cancel button.

reassign to Dan, per today's meeting.

Samir is now working on this. nsXPInstallManager needs to support a private (nsPIXPI..) interface that allows the dialog to poke the cancel value into the manager. The manager should then stop the downloads if we're in that phase (send errors to Necko?) and if during an install should send signals back to the install script (via the notifier functions?).

Pushing this out since new dialog is not in

Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall Engine

Fix should surface in today's builds. You can cancel during download. Once teh download phase completes and the install phase starts the cancel button is disabled. This is a design decision to accomodate multitriggers.

Verified in build 1999122023.

Sorry, made a mistake and verified the wrong bug.

Ummm, like I marked this RESOLVED/FIXED earlier today.

Build 2000-01-03-09-M13(WIN), 2000-01-03-08-M13(MAC), 2000-01-03-08-M13(LINUX) Cancel button automatically appears disabled from progress dialog for all platforms.

Per my comment you can only cancel during download, not during install. You need to download something large. The cancel button will be enabled during download. As soon as extraction of files begins the cancel button is disabled. This is by design: during a multitrigger, say of a.xpi, b.xpi, and c.xpi, respectively, once a.xpi upgrades software package a, and you are in the middle of b.xpi, if you cancel during install there is no way to revert the upgrade action for a.xpi. Thus, our design decision after some deliberation was to disable teh cancel button once extraction begins. Resolving bug as fixed again.

Note that the dialog heading will change from "Downloading" to "Installing" at the point where the cancel button becomes inoperable in the future, to signal the change in state. We will review this with the UE guys, perhaps the cancel button needs to disappear rather than get disabled.

Build 2000-01-03-09-M13(WIN), 2000-01-03-08-M13(MAC), 2000-01-03-08-M13(LINUX) Uh, yeah. It's working.