Very interesting wheel you have there. It looks a lot like the wheel that most of us know as PL_strdup() or nsCRT::strdup() however. This is referring to the lines after if (err == REGERR_OK) after getting NR_RegGetEntryString().

This strdup is using PR_Malloc. The has to free this using PR_Free. Changing this to nsCRT will mean changing all callers. Minor.

scc was (is still?) working on fixing allocation and deallocation of all char* data in the product. It stands to reason that any callers in this case would need to be corrected anyway. Is this not so? Should this be re-opened?