Closed Bug 1080 Opened 26 years ago Closed 26 years ago

{vmargin} top/bottom block margins and floaters don't mix well

Categories

(Core :: Layout, defect, P2)

x86
Windows NT
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: kipp, Assigned: buster)

References

()

Details

When a block is going to carry-out the top/bottom margins the floaters in it cannot be positioned properly becaues the top/bottom margin value is applied sometime later by some outer block frame. When this happens the floater needs to be repositioned.
Status: NEW → ASSIGNED
*** Bug 1120 has been marked as a duplicate of this bug. ***
*** Bug 1071 has been marked as a duplicate of this bug. ***
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Since 1071 appears fixed (see bug report for comments) and was marked as a duplicate of this bug, I'm going to mark this as verified. Please re-open if there are corner cases that aren't covered by 1071 that you think should be investigated as part of verification of this bug; thanks!
Status: VERIFIED → REOPENED
Yes, the case described by 1120, which was also marked as a duplicate of this bug, has not been fixed. Since the page has been changed since the report, I made a version that shows the bug and put the URL above. (http://www.fas.harvard.edu/~dbaron/tests/nglayout/topmarg2.html) I'm reopening the bug.
QA Contact: 3847
Resolution: FIXED → ---
Thanks a lot, David. [QA Assigning to Jan, since this is CSS.]
Actually this one should go to Christine Dreckman (chrisd). Re-assigning QA.
QA Contact: 3847 → 4110
Summary: top/bottom block margins and floaters don't mix well → {vmargin} top/bottom block margins and floaters don't mix well
Severity: normal → major
Status: ASSIGNED → RESOLVED
Closed: 26 years ago26 years ago
Resolution: --- → FIXED
Finally, we pass this test...Look for it working with tommorows builds.
Status: RESOLVED → REOPENED
You're not collapsing margins on floats, and thus the first test in http://www.fas.harvard.edu/~dbaron/tests/nglayout/topmarg3 has too much yellow. I added the last 2 tests - you can see that you're not collapsing from the last test. Reopening bug.
Status: REOPENED → ASSIGNED
Resolution: FIXED → ---
Status: ASSIGNED → RESOLVED
Closed: 26 years ago26 years ago
Resolution: --- → FIXED
Fixed (again). This time for sure (I hope).
Target Milestone: M4
chrisd, could you verify with latest build please? Thanks!
Status: RESOLVED → VERIFIED
Verified fixed.
You need to log in before you can comment on or make changes to this bug.