Closed Bug 10829 Opened 25 years ago Closed 25 years ago

MLK: leaking webshell(s)

Categories

(Core :: DOM: Navigation, defect, P3)

defect

Tracking

()

VERIFIED FIXED

People

(Reporter: bruce, Assigned: nisheeth_mozilla)

Details

(Keywords: memory-leak)

July 28, 1999 pull/build on Solaris 2.6 with gcc 2.7.2.3. Ran viewer and _only_ loaded about:blank. Exiting either via window manager close box or the menu both seemed to leak a webshell. I believe this also happens in apprunner, but haven't confirmed. This may also be the cause of the editor crash at shutdown.
http://www.cybersight.com/~bruce/viewer.about.blank.19990729.log may contain useful information. it is the purify log from this run.
Assignee: brendan → nisheeth
This ain't my bug (see http://www.mozilla.org/owners.html and bug a despot such as leaf@mozilla.org to fix any bugs in that doc by driving http://cvs-mirror.mozilla.org/webtools/despot/despot.cgi). I'm giving it to the webshell owner of the month, nisheeth -- but next milestone, scc owns webshells, so I'm cc'ing him. /be
Were GFX widgets turned on for this test? I'm not sure if the Ender text widget is deleting webshells that it creates. Buster will know more.
I ran 'viewer.pure about:blank' .. standard build. Necko, GTK widgetry, editor, mailnews enabled. Are gfx widgets on by default in this case yet?
GFX widgets by default are "partially" on. This partial state does NOT include ender-backed text controls, so we're clear. No extra webshells from us.
Status: NEW → ASSIGNED
Target Milestone: M9
Accepting bug. Setting milestone to M9... I'll take a look at this as soon as my build finishes.
For some reason, the content sink is not getting destroyed. The content sink holds onto the webshels, hence the leak. Will update as I know more...
I have a fix for this. The HTML DTD was doing an extra ADDREF on the HTML content sink. Chris, please give me permission to check in the fix. Thanks.
I noticed some time ago a circular ref counting problem between content sinks and the parser, which would result in neither of them ever getting freed; filed as bug 8975. That may be related.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
I just checked in the fix in CNavDTD.cpp. I looked at bug 8975 and I think thats a different problem which also needs to be fixed. I'm marking this bug fixed.
Status: RESOLVED → VERIFIED
I just built this and tested. This part looks good. Unfortunately, we now leak 60k at startup in component registration. Filing a new report for that. Thanks nisheeth for the rapid work.
Component: XP Miscellany → Embedding: Docshell
Keywords: mlk
You need to log in before you can comment on or make changes to this bug.