Closed
Bug 1115
Opened 26 years ago
Closed 26 years ago
JavaScript build error
Categories
(Core :: JavaScript Engine, defect, P2)
Tracking
()
VERIFIED
FIXED
M7
People
(Reporter: raff, Assigned: mike+mozilla)
Details
When building on an ARM Linux box (i.e. NetWinder) the compilation of
some JavaScript modules breaks because an error in js/src/jscpucfg.h
(line 360: #error "linux cpu architecture not supported by jscpucfg.h")
The following lines fix the problem:
Index: jscpucfg.h
===================================================================
RCS file: /cvsroot/mozilla/js/src/jscpucfg.h,v
retrieving revision 3.2
diff -r3.2 jscpucfg.h
355a356,358
> #elif __arm__
> #define IS_LITTLE_ENDIAN 1
> #undef IS_BIG_ENDIAN
Also, the code could be made more independent from the processor by
using the definitions in /usr/include/endian.h - Something like the
following should do it:
#include <endian.h>
#if BYTE_ORDER == LITTLE_ENDIAN
#define IS_LITTLE_ENDIAN 1
#undef IS_BIG_ENDIAN
#elif BYTE_ORDER == BIG_ENDIAN
#define IS_BIG_ENDIAN 1
#undef IS_LITTLE_ENDIAN
#else
#error "linux cpu architecture not supported by jscpucfg.h"
#endif
Assignee | ||
Comment 1•26 years ago
|
||
Thanks for the heads up and the short fix. Is all that's necessary to make
everything kool for the ARM?
Discussions are underway as to just how and where to handle OS configuration
issues, both for the javascript module and for mozilla in general. I'll make
sure that something like this fix makes it into whatever system we end up using.
I'll ping you for help testing it.
- Mike
Assignee | ||
Comment 2•26 years ago
|
||
Thanks for the heads up and the short fix. Is all that's necessary to make
everything kool for the ARM?
Discussions are underway as to just how and where to handle OS configuration
issues, both for the javascript module and for mozilla in general. I'll make
sure that something like this fix makes it into whatever system we end up using.
I'll ping you for help testing it.
- Mike
Comment 3•26 years ago
|
||
We have changed it so that jscpucfg.h is auto-generated at build-time
and stored and dist'ed into platform-specific directories. Also, the
name of the file has been changed to jsautocfg.h. That means you can
hold onto your jscpucfg.h patches, since they shouldn't be necessary.
These changes are still on the JavaScript development branch, so you won't see
them in mozilla until that branch lands. If you can wait and you want to test
the changes, you can build with the JavaScript development branch like this:
1) Check out mozilla normally
2) cd mozilla/js/src; cvs up -l -rSpiderMonkey140_BRANCH
3) Build mozilla in the usual way
4) Once you are done testing, you can return your JS directory to the trunk:
cd mozilla/js/src; cvs up -A
Let me know of any problems that you find. In particular, I've only tested
the classic build and not the autoconf build.
Comment 5•26 years ago
|
||
per leger, assigning QA contacts to all open bugs without QA contacts according
to list at http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser
Assignee | ||
Updated•26 years ago
|
Target Milestone: M4 → M7
Assignee | ||
Comment 6•26 years ago
|
||
Moving to m7 as a placeholder until I can get confirmation from somebody who
builds ARM that this is fixed.
Assignee | ||
Updated•26 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•26 years ago
|
||
Eric Perlman confirm that the ARM builds just fine. Closing...
Changing component to "Javascript Engine". "Javascript" component is being
retired.
closing since mccabe says that this built okay. i don't have a linux box of
this flavor.
You need to log in
before you can comment on or make changes to this bug.
Description
•