Now that some (well one) of the browser components is using MDB, it seems to make sense to promote the mdb and mork code to its own top-level directory in the mozilla tree. brendan, davidmc, bienvenu, mscott, putterman, and I have had some private emails about this. We are still waiting from the stamp of approval from brendan. I assigned this to mscott since he seemed, uh, so excited to do this. Please feel free to reassign it back to me if you find that you won't have time. I added the dependency; I have no problem fixing the build system. leaf: I think we'll need to get you involved to shuffle around repository files so that CVS logs aren't lost.

this is the part where i thank everyone for consulting me. thanks. I really, *really* dislike moving stuff in the repository. Unfortunately, it sounds like the right thing to do. I'd like to wait until after the M9 milestone has been released, though.

Sounds good. Moving to M10.

Yes, let's wait until after M9. There are a few other tree reorgs to do then, which I'm writing up and posting on mozilla.org. Hey leaf, I'll sit in the pit and supply you with cordials. /be

*** Bug 11560 has been marked as a duplicate of this bug. ***

*** Bug 11385 has been marked as a duplicate of this bug. ***

Hey Leaf, do you want to get together tomorrow and talk about how we want to do this? We'll want to coordinate moving the files with corresponding build and project changes. I'd like to do this soon if we can. I can set up a meeting if you are interested or we can do it through the bug report.

I would really appreciate it if you would coordinate this with davidmc - see if he's able to check in his tree within the next day or two before going forward.

Davidmc already posted to a newsgroup thread that he was a long way off before being ready to land his latest changes and he thought it best that we just go ahead and do it and he'll catch up when it's done. So we've already got that angle covered.

I'll see if I can stub things enough to build, and then I might be able to hit a checkin this afternoon.

David, that sounds good. I think it makes the most sense to just wait until you have a chance to synch up these changes. It will probably have the least impact on you that way. We'll hold off until we hear back from you.

Hi David, how close are you looking to getting your files checked in? We'll move mdb as soon as your ready with your stuff (assuming appropriate coordination with leaf on my part).

I can do it on a small amount of lead time, so I can stub out loose ends in code I am writing; I was ready last week, but the tree was either closed or in flames whenever I was ready to check in. Rather than twiddle my thumbs, I write more code in Mork since I have more features to implement. So at any given moment, I am not ready to checkin unless I have recently resolved all interface and linkage issues, and actually tried a simple smoke test to look for basic problems. As near as I can tell, I won't be able to check in unless is is part of a carpool, since otherwise I might never see a window of opportunity. Unlike other folks, I don't just check in and then fix breakage afterwards -- unless I am given the go ahead to do this. Maybe after I get a Linux box, I will have some faster and better quality turn around when I sync with the tree; as it is with my two year old and unpowered Mac, a tree sync takes several hours to finish building, and a single problem (such as hitting somebody's partial checkin), tends to blow me out of the water completely. (But the worst case does not happen unless the Mac build system changes again, or unless the tools have changed in some unannounced way that causes me to need to clobber, but I have to cycle a couple times uselessly in order to discover this might be so.)

Let's schedule a carpool. When should it be? I'll send cyeh mail.

i'm going to talk to brendan today about the necko move. It may happen on Labor day monday, but if that precludes us moving mork at the same time, i'd like to push it back. Since we're going to have to make everyone re-checkout large hunks of their local trees, we should give them about a week of notice, and keep the tree closed on a day that isn't already bogged with the daily verification. David, would you be able to do a Monday landing (despite it being a holiday)?

I hadn't heard about the necko move. I think the mork move is orthogonal. Also, David could check in in a carpool on Friday, for example, and the mork move could happen on Monday without him. The Mork checkin and the mork move don't have to happen at the same time.

Yes, I can take another day as holiday instead. I never seem to take my kids away on trips for holidays, so I'm always around and one day off is about like another (though three consecutive days is better than only two, since this causes me to do less mental paging to switch gears between personal coding and Netscape coding).

Looks like we are talking abouting moving these files on Monday at the earliest. So I'm changing the target fix to M11.

*** Bug 12862 has been marked as a duplicate of this bug. ***

I'm going to checkin the project changes for windows and unix in a few minutes. I'll probably transition the Mac later tonight. The mailnews\db directory has been locked down since leaf moved the files so it shouldn't be a problem if I stagger the conversion on the Mac until later tonight.

Build changes for all three platforms are now checked into the tree. We should be in good shape. I still have to do a final shake down test to vreify that disable-mailnews now does indeed work again and then I'll mark this bug fixed. many thanks to leaf for moving the files in the repository which made my job very easy.

I just tried to build w/ disable-mailnews for the first time since the changes were made. The build failed with: make[3]: Entering directory `/home/sean/mozilla/db/mork/build' c++ -o nsMorkFactory.o -c -fno-rtti -fno-exceptions -Wall -Wconversion -Wpoint er-arith -Wbad-function-cast -Wcast-align -Woverloaded-virtual -Wsynth -Wshadow -pedantic -Wno-long-long -DMOZILLA_CLIENT -include ../../../config-defs.h -g -f PIC -DOSTYPE=\"Linux2.2\" -I../../../dist/include -I../../../dist/include -I.. /../../dist/include -I../../../include -I/usr/X11R6/include nsMorkFactory. cpp nsMorkFactory.cpp:19: msgCore.h: No such file or directory make[3]: *** [nsMorkFactory.o] Error 1 make[3]: Leaving directory `/home/sean/mozilla/db/mork/build' make[2]: *** [libs] Error 2 make[2]: Leaving directory `/home/sean/mozilla/db/mork' make[1]: *** [libs] Error 2 make[1]: Leaving directory `/home/sean/mozilla/db' make: *** [libs] Error 2 --------- It looks like it still needs msgCore.h from the mailnews directory.

I'll take a look. I just tried to build with disable-mailnews this morning but my build keeps breaking in webshell\embed\gtk. I think kipp just posted to builds about the same problem.

Looks like the include was just in there for "historical" purposes. I removed the #include "msgCore.h" and we still build fine. You can try taking it out on your build. I'll be checking in the change when tinderbox is green.

Hey David, have you had a chance to move any of the files you've modified that aren't checked into the tree up into mozilla\db? I'd like to remove the mailnews files from the repository and close this bug out if you are ready.

I'll be ready soon; I expect to check in next from Linux, after copying my changed files there from Mac, so the changed files will clobber whatever is there and go into the new hierarchy. Technically that means you could delete the old files already, since I won't be syncing on my Mac to check in; but it would feel safer to flush my tree first anyway.

I really really want to close out this bug...by midnight tomorrow night before we close for m11, I'm going to cvs remove them. CVS won't remove the files from your directory if you made changes to them so you won't loose any data...

I've removed all the files in db\mork, db\mork\src, db\mork\build and db\msgdb. Leaf, do we need to do anything special to actually remove these directories and not make them get pulled when you pull the seamonkey tag? Can I just cvs remove the directories? Or do we just leave them empty...