Closed
Bug 11593
Opened 25 years ago
Closed 22 years ago
[CODE CLEANUP] eliminate NS_COMFALSE
Categories
(Core :: XPCOM, defect, P3)
Tracking
()
People
(Reporter: warrensomebody, Assigned: braddr)
References
Details
(Keywords: helpwanted)
We should eliminate the NS_COMFALSE madness once and for all. Here's a list of
offending uses in your module -- please pass the bug along if there's someone
else who should deal with it.
xpcom/base/nsError.h:
View change log or Blame annotations
line 124
xpcom/ds/nsConjoiningEnumerator.cpp:
View change log or Blame annotations
line 111
line 180
line 373
xpcom/ds/nsProperties.cpp:
View change log or Blame annotations
line 132
line 133
xpcom/ds/nsSupportsArrayEnumerator.cpp:
View change log or Blame annotations
line 104
xpcom/ds/nsVariant.cpp:
View change log or Blame annotations
line 107
line 114
line 163
Updated•25 years ago
|
Status: NEW → ASSIGNED
Summary: eliminate NS_COMFALSE → [CODE CLEANUP] eliminate NS_COMFALSE
Target Milestone: M11
Updated•25 years ago
|
Target Milestone: M11 → M15
Assignee | ||
Comment 1•25 years ago
|
||
nsVariant taken care of by nixing it from the tree completely, see 16987
Updated•25 years ago
|
Assignee: dp → braddr
Status: ASSIGNED → NEW
Comment 2•25 years ago
|
||
This does not appear to be an M15 stability blocker (in fact... it is an old
cleanup task... which might be done by now :-/). In any case, I'm pushing it to
M16.
Target Milestone: M15 → M16
Comment 3•25 years ago
|
||
It may be old, But it isn't done :-(
Up to date list
/xpcom/appshell/eventloop/photon/nsCPlatformBaseLoop.cpp
line 66 -- return NS_COMFALSE;
line 95 -- return NS_COMFALSE;
line 110 -- return NS_COMFALSE;
/xpcom/appshell/eventloop/windows/nsCBreathLoop.cpp
line 79 -- return NS_COMFALSE;
/xpcom/appshell/eventloop/windows/nsCPlatformBaseLoop.cpp
line 53 -- return NS_COMFALSE;
line 69 -- return NS_COMFALSE;
line 131 -- return NS_COMFALSE;
/xpcom/appshell/eventloop/xp/nsIDispatchListener.idl
line 52 -- NS_COMFALSE - Processing went successfully, but
line 71 -- return NS_COMFALSE.
/xpcom/appshell/eventloop/xp/nsIEventLoop.idl
line 150 -- NS_COMFALSE - An exit event has been signalled.
line 159 -- PeekNextEvent will return immediately with NS_COMFALSE.
line 160 -- When the queue becomes empty, PeekNextEvent will return
NS_COMFALSE to
line 175 -- implementations, in those that do not support false,
NS_COMFALSE
line 178 -- NS_COMFALSE - There are no more events to retrieve. Or
line 230 -- NS_COMFALSE - Message was Sent but was unable to wait for
event
/xpcom/appshell/eventloop/xp/nsITranslateListener.idl
line 53 -- NS_COMFALSE - Translating went successfully, but
line 72 -- returns NS_COMFALSE.
/xpcom/base/nsError.h
line 130 -- #define NS_COMFALSE 1
/xpcom/ds/nsHashtableEnumerator.cpp
line 248 -- return NS_COMFALSE;
/xpcom/ds/nsIEnumerator.idl
line 36 -- * DO NOT USE THIS INTERFACE. IT IS HORRIBLY BROKEN, USES
NS_COMFALSE
M16 has been out for a while now, these bugs target milestones need to be
updated.
Assignee | ||
Comment 5•24 years ago
|
||
Moving out a few milestones. Anyone want to handle this?
Keywords: helpwanted
Target Milestone: M16 → M18
Comment 6•24 years ago
|
||
dp is no longer @netscape.com. changing qa contact to default for this product
QA Contact: dp → kandrot
Comment 7•24 years ago
|
||
Milestone 0.8 has been released. We should either resolve this bug or update its
milestone.
Updated•24 years ago
|
Target Milestone: M18 → ---
Comment 8•23 years ago
|
||
dupe of 8929
*** This bug has been marked as a duplicate of 8929 ***
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•