Closed
Bug 11597
Opened 25 years ago
Closed 22 years ago
eliminate NS_COMFALSE
Categories
(Core :: XUL, defect, P3)
Tracking
()
People
(Reporter: warrensomebody, Assigned: braddr)
References
()
Details
We should eliminate the NS_COMFALSE madness once and for all. Here's a list of
offending uses in your module -- please pass the bug along if there's someone
else who should deal with it.
widget/src/xpwidgets/nsBaseWidget.cpp:
View change log or Blame annotations
line 566
Comment 1•25 years ago
|
||
I don't know anything about this. I've never written any code in this file.
Reporter | ||
Updated•25 years ago
|
Assignee: hyatt → mjudge
Reporter | ||
Comment 2•25 years ago
|
||
I looked up the author, looks like Mike Judge.
yeah yeah we need to remove it since the javascript calls cant handle it. thats
fine but I dont think i will get to this anytime soon seeing how pervasive the
use of nsIEnumerators are now. the nsIBasicEnumerator is a "basic" version of a
javascript happy interface that should be usable. if anyone REALLY needs this
change then lets start a client wide acknowlegement to use nsIEnumerator2 for
example.
Updated•25 years ago
|
Status: RESOLVED → VERIFIED
Comment 4•25 years ago
|
||
Based on mike's comments, marking as verified won't fix.
Updated•25 years ago
|
Status: VERIFIED → REOPENED
Updated•25 years ago
|
Assignee: mjudge → brendan
Status: REOPENED → NEW
Updated•25 years ago
|
Status: NEW → ASSIGNED
Updated•25 years ago
|
Resolution: WONTFIX → ---
Comment 5•25 years ago
|
||
If no one minds, I'll fix this after beta. There is a client-wide move toward
nsISimpleEnumerator, it's been all over the xpcom newsgroup and in the mozilla
architecture meeting. It isn't going to get constant fanfare, but it has
already happened to a great degree (query bugzilla for resolved bugs to do with
NS_COMFALSE). The mailnews guys have done much great work. Why stop short of
completion?
/be
Reporter | ||
Comment 6•25 years ago
|
||
Good. We should get rid of all this crap like NS_COMFALSE and nsIEnumerator.
I'm glad someone's doing it.
Updated•25 years ago
|
Target Milestone: M15
Updated•25 years ago
|
Assignee: brendan → braddr
Status: ASSIGNED → NEW
Comment 7•25 years ago
|
||
I think braddr is driving this to a good conclusion throughout the tree.
/be
Assignee | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Comment 8•25 years ago
|
||
Since this cleanup task is not an M15 stability blocker, I'm pushing it off to
M16 (to help allow us to branch for M15).
Target Milestone: M15 → M16
Comment 9•24 years ago
|
||
NS_COMFALSE is no longer in /widget/src/xpwidgets/nsbasewidget.cpp
Search shows NO listing for NS_COMFALSE in /widget branch
This bug can be resolved fixed.
Comment 10•24 years ago
|
||
M16 has been out for a while now, these bugs target milestones need to be
updated.
Comment 12•24 years ago
|
||
Milestone 0.8 has been released. We should either resolve this bug or update its
milestone.
Updated•24 years ago
|
Target Milestone: M18 → ---
Comment 13•24 years ago
|
||
Moving to XP Toolkit/Widgets component.
Component: Layout → XP Toolkit/Widgets: Trees
Updated•24 years ago
|
Component: XP Toolkit/Widgets: Trees → XP Toolkit/Widgets
Comment 14•23 years ago
|
||
I think this one was fixed long ago, so could we close it now ?
and perhaps #11592, #11595 and some more in #8929...
/jc
Comment 15•23 years ago
|
||
i count 20 users that usually doesn't match my definition of eliminate (it
might match decimate but ...)
*** This bug has been marked as a duplicate of 8929 ***
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 22 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•