Closed Bug 11626 Opened 25 years ago Closed 25 years ago

[PP]Context menus are broken

Categories

(SeaMonkey :: General, defect, P2)

x86
Linux
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mozilla, Assigned: hyatt)

References

Details

Context menus seem broken. They were working a few days ago. As an example, try this: run apprunner, select "Bookmarks | Manage Bookmarks". You'll get the bookmarks window. Click on a node to select it, then right-mouse click (or, on the Mac, ctrl-key+click) on it to bring up a context menu. It has crap in it.
Priority: P3 → P2
Chris, is there any chance of getting this bug fixed for M9?
Robert, I suspect you are building the menu using "onclick" attributes instead of "onaction" attributes. I changed the syntax a week or two ago, and I probably missed your stuff, since it presumably is built in C++ or JS code rather than being specified in the XUL.
The problem seems to be in setting the "name" attribute, such as: menuItem.setAttribute("name", cmdName); Has that changed to something else?
Oh, and more importantly "name" became "value".
Assignee: saari → rjc
Target Milestone: M9
Yep, that fixes it. :^) Thanks, Chris. I'll take ownership of this bug back, to get it off of your radar. Chris (Hoffman), I'd like check-in permission to fix this for M9. The fix consists of two changes to strings in a JavaScript file. Pretty trivial.
Status: NEW → ASSIGNED
ok, get a review and wait for mac bustage to clear tonight, or after the verfication builds are done on tuesday..
i can supply a review right now.
David, here is the diff: < menuItem.setAttribute("name", cmdName); < menuItem.setAttribute("onclick", "return doContextCmd('" + cmdResource.Value + "');"); --- > menuItem.setAttribute("value", cmdName); > menuItem.setAttribute("onaction", "return doContextCmd('" + cmdResource.Value + "');");
Looks good. This change is safe and trivial. I vote for checking it in when the Mac bustage gets cleared up. Does that sound good, Chris (H)?
do it!
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Fixed checked in.
Status: RESOLVED → REOPENED
works perfectly on WinNT with 1999081308 builds was this an XP problem originally? I ask because they don't work on linux and the debug console has a lot to say when you try I'm blocked by bug 11832 from checking on mac unless you can tell me where else to do a context click that doesn't involve bookmarks or history. As a matter of fact, I'm going to REOPEN this until answered.
Assignee: rjc → saari
Status: REOPENED → NEW
If context menus don't work on Linux, this bug needs to be pointed at the one working on implementing them. I think that's probably Chris Saari... so reassigning to him.
OS: Windows NT → Linux
Resolution: FIXED → ---
Summary: Context menus are broken → [PP]Context menus are broken
I still can't verify if this is fixed on Mac, marking PP linux for now though since they are working on WinNT.
Pavlov is the last man standing on linux context/popups... CC'ing him
this is a duplicate of another bug if we are saying they don't work on linux. this has been pushed off until we have XP context menus.
Target Milestone: M9 → M10
We know that context menus will not be fixed for M9 and this info is on the "most frequent bugs page". MOving to M10
Assignee: saari → hyatt
Giving this to hyatt so he can close it when the popup rearchitecting is done
Blocks: 12670
Blocks: 7520
Blocks: 13465
Status: NEW → RESOLVED
Closed: 25 years ago25 years ago
Resolution: --- → FIXED
resolved as fixed
QA Contact: claudius → cpratt
Status: RESOLVED → VERIFIED
Yes, I see context menus in Linux working OK on M10 builds
No longer blocks: 13465
Moving all UE/UI bugs to new component: User Interface: Design Feedback UE/UI component will be deleted.
Component: UE/UI → User Interface: Design Feedback
Component: User Interface Design → Browser-General
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.