Closed
Bug 12114
Opened 25 years ago
Closed 25 years ago
[mlk] nsBookmarksService leaks
Categories
(Core Graveyard :: RDF, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
M12
People
(Reporter: waterson, Assigned: mozilla)
References
Details
Attachments
(1 file)
|
(deleted),
text/xul
|
Details |
The tree widget, with content generated from an RDF datasource, leaks the
datasource.
|
Reporter | |
Updated•25 years ago
|
|
|
Reporter | |
Comment 1•25 years ago
|
||
|
|
Reporter | |
Comment 2•25 years ago
|
||
To reproduce, download above test case.
1. Run viewer.
2. Set breakpoint in nsBookmarksService::~nsBookmarksService().
3. Open test case.
4. Click "Back" button.
Expectation is that nsBookmarksService() will be destroyed. It isn't.
|
|
Reporter | |
Comment 3•25 years ago
|
||
Urgh. Here's what is happening. The RDF service acquires datasources using the
XPCOM service manager. The XPCOM service manager holds on to the component
UNTIL XPCOM SHUTS DOWN.
This seems evil to me, but I'm not aware of all the issues. See this thread:
news://news.mozilla.org/37BB6D29.451B220F%40netscape.com
|
||
Comment 4•25 years ago
|
||
how big do we think this leak is?
|
|
Reporter | |
Updated•25 years ago
|
Target Milestone: M11 → M12
|
|
Reporter | |
Comment 5•25 years ago
|
||
bulldozer to M12
|
|
Reporter | |
Updated•25 years ago
|
Summary: [mlk] tree widget with generated content leaks datasource → [mlk] nsBookmarksService leaks
|
|
Reporter | |
Comment 6•25 years ago
|
||
this is a different bug now, and i think the leak is happening because of the
extra addref that we do to keep the bookmarks service alive for the timer
callback.
|
|
Reporter | |
Updated•25 years ago
|
Assignee: waterson → rjc
Status: ASSIGNED → NEW
|
|
Reporter | |
Comment 7•25 years ago
|
||
robert, i'm gonna give you this love. it's the timer-leaking-bookmarks thingy.
|
Assignee | |
Updated•25 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•25 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 8•25 years ago
|
||
Fixed. Instead of doing an extra refcnt for the nsBookmarksService in the timer,
we now simply cancel the timer in the nsBookmarksService DTOR.
|
||
Updated•25 years ago
|
Status: RESOLVED → VERIFIED
|
|
||
Comment 9•25 years ago
|
||
marking verified
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•