The lines: PRInt32 i = mChildren->IndexOf(aKid); NS_ASSERTION(i < 0, "element is already a child"); if (i >= 0) return NS_ERROR_FAILURE; make little sense, either the interface supports checking for duplicate insertions and the NS_ASSERTION should be removed, or the interface doesn't support it and then the "return NS_ERROR_FAILURE" should be removed. I would suggest replacing these lines with NS_ASSERTION(mChildren->IndexOf(aKid) < 0, "element is already a child"); to prevent the IndexOf enumeration from happening in non-debug builds. (It's pretty minor, the only 50+ elements enumeration I could find was when starting up the editor)

Yep, this is dumb. We should be checking in the implementations of the DOM APIs, not the content APIs. Good catch.

damn, i can't believe i've sat on this for so long. fix checked in. thanks zee.

Changing QA Contact to ckritzer@netscape.com

verified

BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL. XUL component will be deleted.