To make the progress dialog easier to use by the nsIChannels, it should implement the following interfaces: nsIProgressEventSink nsIInterfaceRequestor In this way, the progress dialog can be opened and directly attached to a channel.

Doug, I think this is a worthwhile extension. Questions: What about handling errors that come through onStatus? Presumably, those would need to be translated into calls to the onStatusChange method. There might also have to be some filtering to ensure that only errors go through (similar to what nsWebBrowserPersist::OnStatus does). Wouldn't we also have to hook into nsIStreamListener methods for OnStopRequest notifications (with mapping to OnStateChange)? Maybe another approach would be to write a generalized wrapper class that implements nsIWebProgressListener around a nsIProgressEventSink and nsIStreamListener?

>Maybe another approach would be to write a generalized wrapper class that implements nsIWebProgressListener around a nsIProgressEventSink and nsIStreamListener? Yes. that is the best thing to do. An adaptor class. Are you up to do this?

The only problem is that, we could not use your interface directly. :-(

OK, maybe the adapter isn't worth the trouble. But I still don't have time to deal with this, unless you get it marked nsbeta1+ and added to my mozilla1.0 bug list.

Charlie is interested in this, too. Maybe he can help out?

-> law

-> me

-> me

i'm going to mark this WONTFIX based on the fact that it is easy enough to use nsIWebBrowserPersist + nsIProgressDialog to achieve the effect. if someone really wants this, then please speak up ;-)

(In reply to comment #10) > i'm going to mark this WONTFIX based on the fact that it is easy enough to use > nsIWebBrowserPersist + nsIProgressDialog to achieve the effect. if someone > really wants this, then please speak up ;-) well... you actually implemented nsIInterfaceRequestor on it...