StrAllocCopy() and other such string manipulation functions need to go away in favor of nsString and family.

*** Bug 13508 has been marked as a duplicate of this bug. ***

awaiting code review. -p

checked in. closing bug. -pn

bruce@cybersight.com, would you like to verify this bug? (Or, I can rubber-stamp it verified.) Thanks!

I confirmed via lxr that this has been removed, except for the defines for it in modules/libimg/src/xpcompat.h Since these were also just defines for NET_SACopy and NET_BACopy (if we include BlockAllocCopy() in this as well), then that code can be removed from modules/libimg/src/xpcompat.cpp as well. This would help insure that we don't see code using these skeletons popping back up again in the future.

Re-opening to ensure bruce's comments hits Pam's radar screen. Thanks, Bruce!

The NET_B* calls have been removed from xpcompat.*. The only component using it was gifcom, so I took the code, used nsCRT calls and put it in the gif code. xpcompat.* is still alive due to the timer calls and the XP_GetString function which pulls out strings out of a monster include file. The mac still has some timer issues. And the XP_GetString function will be replaced with 'string bundle' funtions. All of the imglib string manip code has been replaced with nsCRT code. -pn

Looks good! If this gets marked as resolved, I think it should also be marked as verified (looked at stuff via bonsai).

Clearing FIXED resolution due to reopen. pnunn, not sure if this should be Resolved since reopen. Please re-mark as Resolved/Fixed if all is well. Thanks!

Not a blocker for Dogfood...marking [PDT-]

The mac build upchucked all over the place when xp_mcom.h was removed. I have to dig in there and find out why its unhappy. The include file was put in for a temp fix for the mac build. Lets keep it open until all issues resolved. -pn

Ok. This bug should have been marked fixed. I will reopen a new bug for the mac issues in gifcom. -pn

Bruce or Brendan, would one of you like to verify this, or should I rubber-stamp it as verified? Thanks!

QA Assigning to Bruce. Please QA assign back if you'd rather not, and I'll just rubber-stamp it verified.

One rubber stamp is good as another. Looked good with a quick peek in LXR.