Closed Bug 14022 Opened 26 years ago Closed 24 years ago

IME98 Reconversion does not work in HTML Editor

Categories

(Core :: Internationalization, enhancement, P2)

x86
Windows 98
enhancement

Tracking

()

VERIFIED FIXED

People

(Reporter: teruko, Assigned: shanjian)

References

Details

(Keywords: helpwanted, Whiteboard: [nsbeta2-][nsbeta3+])

Attachments

(5 files)

(This bug imported from BugSplat, Netscape's internal bugsystem. It was known there as bug #180611 http://scopus.netscape.com/bugsplat/show_bug.cgi?id=180611 Imported into Bugzilla on 09/16/99 11:02) Tested 4.06 6-23-98 Win32 build under Window 98J final beta. Window 98J comes with IME 98. IME 98 has several new features. One of it's new feature, reconversion, does not work in HTML composer and HTML mail composer. Step of reproduce 1. Open HTML composer 2. Change encoding to Japanese(Auto-Detect) by selecting menu view|encoding-Japanese(Auto-Detect) 3. Ctrl ~ to turn on IME 4. Type Japanese characters, like "表示" and hit Enter 5. Select the characters you just typed and right click At this time, the "reconversion (再変換)", and "Japanese Input-On(日本語入力 -オフ)" popup menu should display. If you try to do the same thing in Address book or other edit area, this popup shows up and it works fine.
set tfv to 5.0; reassign to mudge; set priority (temporarily; at least during stability mode) to P3
"reconversion" (再変換) is new feature of IME 98. In Window 95 and WinNT 4.0, after you type Japanese characters and hit return, you cannot convert the Hiragana or Katakana to other kanji. However, this "reconversion" function allows us to select the characters you typed and committed. The popup menu does not show up and does not work in HTML editor and HTML composer.
nhotta found this documention on Re-conversion implementation: http://www.microsoft.com/japan/office/ime/api/MSIMEIF_perimeinterfaces.htm Update from Mozilla: So far no takers.
Status: RESOLVED → REOPENED
OS: Windows 95 → Windows 98
Assignee: mjudge → tague
Status: REOPENED → NEW
Component: Editor → Internationalization
Priority: P3 → P2
Summary: IME98 Reconversion does not work in HTML composer → IME98 Reconversion does not work in HTML Editor
Severity: major → enhancement
Status: NEW → ASSIGNED
Target Milestone: M20
reconversion is an out feature for now, taking under advisement
Whiteboard: HELP WANTED
reconversion would be a really nice feature to have but it's currently on the "out" list for the first release of mozilla. if anyone wants to contribute some time, it would really improve the product.
Blocks: 14356
Blocks: 16127
bulk reassign bugs to ftang for now
Status: NEW → ASSIGNED
Keywords: helpwanted
Whiteboard: HELP WANTED
cc'd m_kato who seems to be an expert on IME issues...
add m_kato@ga2.so-net.ne.jp to the cc list
Nominating this bug for beta2 since this is beta2 criteria. in http://client/seamonkey/prd/beta2criteria.html#I18N Browser
Keywords: nsbeta2
Putting on the [nsbeta2+] radar.
Whiteboard: [nsbeta2+]
Attached patch patch of mozilla/editor (deleted) — Splinter Review
Attached patch patch of mozilla/dom (deleted) — Splinter Review
Attached patch patch of mozilla/widget (deleted) — Splinter Review
This patches will support the following environment. o Windows 98 / 2000 o Windows 95 / NT 4.0 + MS-IME98/2000 o Windows 95 / NT 4.0 + ATOK 12/13 I tested on Windows 98 SE and Windows NT 4.0 + ATOK13
IME related issue. Reassign to shanjian. It seems m_kato propose a fix. shanjian, please work with jfrancis to review the editor , dom and layout/events changes.
Assignee: ftang → shanjian
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
Shanjian, I installed Japanese IME to Windows 2000 US. Reconversion works fine notepad, IE 5.0 in Windows 2000 US with Japanese IME.
Add jfrancis to cc list. Joe, could you take a look at the fix? It looks fine to me, but I would like you to take a look before I check them in.
okee doke - i'll do that tonight.
I'm not sure what to say about this. GetReconversionString() is doing some things that are disturbing. On thing is relying on GetFocusNode from selection to always return the node you want. That might always work for now, but I wonder if we cant just know what the current ime text node is independent of that. But more worrisome is that GetReconversionString() is removing a textnode from the document directly, instead of going through the editor. This is going to mess up undo. It would also mess up editor playback using Kin's event recording mechanism. I will be out of town today (the 15th), and back on the 16th. If you need to talk about this today, I'll ask kin@netscape.com to stand in for me. Otherwise, we can talk about this Friday I guess.
Wrote by jfrancis: Why does this routine GetReconversionString() need to null out a whole text node? I don't understand it from looking at the bug report. What is the sequence of events for reconversion? Can the user reconvert any substring that was previously committed? If so, what possible correspondence does this have with a whole text node, which might contain an arbitrary number of commited IME characters, not neccessarly just those selected? I need someone to explain to me in some detail what is _supposed_ to happen. Then it should be no problem for me to write the portion of the implementation that has to live in the editor.
Whiteboard: [nsbeta2+] → [nsbeta2+], wait for jfrancis to rewrite GetReconversionString()
Mark this minus after talk to shanjian. We can ship nsbeta2 without this.
Whiteboard: [nsbeta2+], wait for jfrancis to rewrite GetReconversionString() → [nsbeta2-], wait for jfrancis to rewrite GetReconversionString()
nsbeta3+ per i18n bug meeting. m_kato@ga2.so-net.ne.jp, can you work with shanjian to resolve what jfrancis do not agree w/
Keywords: nsbeta3
Whiteboard: [nsbeta2-], wait for jfrancis to rewrite GetReconversionString() → [nsbeta2-][nsbeta3+] wait for jfrancis to rewrite GetReconversionString()
Attached file GetReconversionString() (deleted) —
I've attached an attempt at writing GetReconversionString(). I haven't actually compiled it. I didn't want to apply all the patches since I don't have a way to test this. Let me know if there are problems...
fixed has been checkin for Kato san. Great Job, makoto kato.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
I'm hoping that means ther werne't any problems :-)
I tested this in 2000-08-13-08 Win32 build with Win98J. This does not work. After I typed Japanese characters and committed the characters, the reconversion item is not in the popup menu when I selected the characters. I tried this in Composer, Text area, new mail composer, and Plaintext editor, but the reconversion for IME 98 does not work.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
teruko, If you press the reconversion button on IME tool bar, you will reconversion itself works. Let's treat reconversion missing on popup menu as a separate problem. Could you file a new bug about that? In near future, I do not see a way to do that.
Whiteboard: [nsbeta2-][nsbeta3+] wait for jfrancis to rewrite GetReconversionString() → [nsbeta2-][nsbeta3+]
shanjian- what is working and what is not. Can you outline the impact of the fix ?
Ok, If I press the reconversion button on IME tool bar, reconversion worked fine. I mark this as fixed. I will log the separate bug about missing on popup menu for reconversion.
Status: REOPENED → RESOLVED
Closed: 24 years ago24 years ago
Resolution: --- → FIXED
I verified this in 2000-08-17-08 Win32 build with Win98J and Windows 2000J.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: