Closed
Bug 14672
Opened 25 years ago
Closed 25 years ago
unreachable code in extensions/wallet/src/wallet.cpp
Categories
(Core Graveyard :: Tracking, defect, P3)
Core Graveyard
Tracking
Tracking
(Not tracked)
VERIFIED
FIXED
M14
People
(Reporter: colin, Assigned: morse)
Details
Not sure which component to assign this extensions/wallet concern to.
Something is amiss with this code fragment from
extensions/wallet/src/wallet.cpp:
for (;;) {
nsAutoString * aItem1;
if (NS_FAILED(wallet_GetLine(strm, aItem1, PR_FALSE))) {
/* end of file reached */
break;
strm.close();
return;
}
.
.
.
The strm.close and return statements can never be reached!
Colin.
Updated•25 years ago
|
Assignee: chofmann → morse
Assignee | ||
Updated•25 years ago
|
Target Milestone: M14
Assignee | ||
Comment 1•25 years ago
|
||
You are absolutely right. It turns out that either deleting the "break" or
deleting the two lines folling the "break" would have the identical effect on
the program flow so either of those fixes are acceptable. Trivial and safe fix.
But it's not on the beta list so I can't make that fix until M14. Marking tfv
as such.
Assignee | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•25 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 2•25 years ago
|
||
Checked in the fix to wallet.cpp
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•