Created by Rick Osborne (rick@rixsoft.com) on Saturday, April 11, 1998 9:37:24 PM PDT Additional Details : (In the continuing quest to eliminate even compiler warnings ... ) Just a couple of cases of compiler directives mucking with variable scopes. The last one was a bit tricky, but I figured it out. It boils down to the fact that the compiler just eliminates the call because it simplifies to if(!1). So, you take the variable out of the picture when that case occurs (global threads). --- prucv.c Sun Apr 12 00:33:55 1998 +++ prucv.old.c Wed Apr 08 17:55:09 1998 @@ -157,9 +157,7 @@ void _PR_NotifyLockedThread (PRThread *t PRStatus _PR_WaitCondVar( PRThread *thread, PRCondVar *cvar, PRLock *lock, PRIntervalTime timeout) { -#ifndef _PR_GLOBAL_THREADS_ONLY /* is isn''t used in that context */ intn is; -#endif PRStatus rv = PR_SUCCESS; PR_ASSERT(thread == _PR_MD_CURRENT_THREAD()); @@ -530,10 +528,8 @@ PR_IMPLEMENT(PRStatus) PR_NotifyCondVar( */ PR_IMPLEMENT(PRStatus) PR_NotifyAllCondVar(PRCondVar *cvar) { -#ifndef _PR_GLOBAL_THREADS_ONLY /* is and q not used in that context */ PRCList *q; PRIntn is; -#endif PRThread *me = _PR_MD_CURRENT_THREAD(); PR_ASSERT(cvar->lock->owner == me); @@ -618,11 +614,7 @@ PR_IMPLEMENT(PRStatus) PRP_NakedNotify(P PR_IMPLEMENT(PRStatus) PRP_NakedBroadcast(PRCondVar *cvar) { PRCList *q; -#ifndef _PR_GLOBAL_THREADS_ONLY - /* since this is all macro''ed, we get a warning in the above case due to - the compiler throwing out the call and thinking the var goes unrefed */ PRIntn is; -#endif PRThread *me = _PR_MD_CURRENT_THREAD(); PR_ASSERT(_PR_NAKED_CV_LOCK == cvar->lock); Updated by Wan-Teh Chang (wtc@netscape.com) on Friday, April 24, 1998 12:33:41 PM PDT Additional Details : Assigned bug to myself.

Ditto on this one.

per leger, assigning QA contacts to all open bugs without QA contacts according to list at http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser

Wan-Teh, these are some pretty old bugs. i can't help but assume they have been fixed by now. If you don't have any objections, i will close out and verify these bugs in a couple of days: 146, 148, 149, 150, 151, 152, 154

please take corrective action if this is not doing the Right Thing, but, as it has been a while, i'm marking these fixed and will immediately verify: bugs 146, 148, 149, 150, 151, 152, 154

verified.

NSPR now has its own Bugzilla product. Moving this bug to the NSPR product.