Closed Bug 15155 Opened 25 years ago Closed 22 years ago

Dropping down comboboxes causes reflow

Categories

(Core :: CSS Parsing and Computation, defect, P4)

x86
Windows NT
defect

Tracking

()

RESOLVED WORKSFORME
Future

People

(Reporter: peterl-retired, Assigned: dbaron)

References

Details

(Keywords: perf, Whiteboard: [dogfood-])

This is due to the use of 'visibilty' collapse. I have an optimization I can make once box frames stop using collapse for reflow purposes.
Assignee: peterl → pierre
The code in StyleDisplayImpl::CalcDifference for visibility should only return NS_STYLE_HINT_REFLOW if the mDisplay is table row or table col. This needs still needs to be reconciled with nsBoxFrame's usage of collapse first.
Blocks: 16950
Whiteboard: [dogfood]
Priority: P3 → P2
Target Milestone: M12
Blocks: 17432
Blocks: 18951
Blocks: 20203
Target Milestone: M13 → M14
Moving [DOGFOOD] in Status Summary to dogfood in keyword field.
Keywords: dogfood
Whiteboard: [dogfood]
Old bug, still a problem. for dogfood?
Whiteboard: [NEED INFO]
PDT-
Whiteboard: [NEED INFO] → [PDT-]
*** Bug 29605 has been marked as a duplicate of this bug. ***
Moving crufty m14-m15 bugs out to m16 for proper triage.
Target Milestone: M14 → M16
Target Milestone: M16 → M17
Putting on [dogfood-] radar.
Whiteboard: [PDT-] → [dogfood-]
*** Bug 31257 has been marked as a duplicate of this bug. ***
transferring perf keyword and cc list from dup'd bug 31257
Keywords: perf
Pierre pique'd my interest in this one, so I added myself to the CC list. I'll try to contribute some ideas based on Pierre's prior efforts soon.
No longer blocks: 17432
No longer blocks: 18951
No longer blocks: 20203
Block moved M17 bugs to mozilla0.9
Target Milestone: M17 → mozilla0.9
Netscape's standard compliance QA team reorganised itself once again, so taking remaining non-tables style bugs. Sorry about the spam. I tried to get this done directly at the database level, but apparently that is "not easy because of the shadow db", "plus it screws up the audit trail", so no can do...
QA Contact: chrisd → ian
Keywords: nsdogfood-
Keywords: nsdogfood
Target Milestone: mozilla0.9 → mozilla1.0
It doesn't seem to be a problem anymore. We'll check it out for a future milestone.
Priority: P2 → P3
Target Milestone: mozilla1.0 → Future
I think this is based on misuse of the meaning of 'visibility: collapse', which should generally cause a reflow (based on what it means for tables, which is the only thing it really applies to in the CSS spec). One possible improvement, though, would be to have ComputeDisplayData change 'collapse' to 'hidden' in some cases. It seems a bit odd to poke at other structs in CalcStyleDifference. Is this still an issue for comboboxes? I suspect not, and even if it is it's unlikely to be once XBL form controls are turned on.
Priority: P3 → P4
Assigning pierre's remaining Style System-related bugs to myself.
Assignee: pierre → dbaron
Status: ASSIGNED → NEW
this page has enough comboboxes to test, but I don't see any (visible) reflow..?!
Is this bug still valid at all?
We seem to handle this by hiding or showing the popup view now... jkeiser? roc? Could you verify that please?
I don't think 'visibility:collapse' is used for the dropdown anymore.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.