Closed Bug 15174 Opened 25 years ago Closed 24 years ago

[fix in hand]counter() and counters() should not be recognised by CSS parser

Categories

(Core :: CSS Parsing and Computation, defect, P3)

defect

Tracking

()

VERIFIED FIXED

People

(Reporter: ian, Assigned: pierre)

References

Details

(Keywords: css1, Whiteboard: [fix in hand][nsbeta3+])

Attachments

(1 file)

If counter() and counters() are not implemented, then the entire 'content' declaration in which they occur should be ignored. That is so that authors can easily work around this lack of feature. NOTE! THIS IS CURRENTLY A BUG! i.e., currently, the following: SPAN:before { content: "works"; } SPAN:before { content: counter(x) "bug!"; } ...displays "bug!". It should not, since counters are not supported. It should display either "works" or "1bug!" (note the "1"). This is due to the forward-compatability parsing rules: if a feature is not supported, then the declaration should be ignored. If counters are going to be implemented, then this bug is invalid. If they are not going to be implemented, though, then this should be fixed before release. Counter support is covered by bug 3247.
Depends on: 3247
Status: NEW → ASSIGNED
Target Milestone: M20
Good point. Deferring until just before release. I don't want to turn things off just yet...
Reassigning peterl's bugs to myself.
Accepting peterl's bugs that have a Target Milestone
Keywords: css1
Migrating from {css1} to css1 keyword. The {css1}, {css2}, {css3} and {css-moz} radars should now be considered deprecated in favour of keywords. I am *really* sorry about the spam...
Summary: {css1} counter() and counters() should not be recognised by CSS parser → counter() and counters() should not be recognised by CSS parser
As per meeting with ChrisD today, taking QA.
QA Contact: chrisd → py8ieh=bugzilla
Nominating for nsbeta3. It is important that we do not break future compatability for when we fully implement this feature.
Keywords: correctness, nsbeta3
Easy fix per pierre. [nsbeta3+].
Whiteboard: [nsbeta3+]
Summary: counter() and counters() should not be recognised by CSS parser → [fix in hand]counter() and counters() should not be recognised by CSS parser
Whiteboard: [nsbeta3+] → [fix in hand][nsbeta3+]
Target Milestone: M20 → M18
Fix checked in nsCSSParser.cpp
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Attached file Simple testcase (deleted) —
Per testcase, VERIFIED FIXED.
Status: RESOLVED → VERIFIED
For my own reference, if nobody else: To reenable counters in parsing, comment in line 81 below in layout/html/style/src/nsCSSParser.cpp 79 // so we can use "mozoutline 80 81 //#define ENABLE_COUNTERS // un-comment this to enable counters (bug 15174) 82 83 MOZ_DECL_CTOR_COUNTER(SelectorList)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: