Closed Bug 1544 Opened 26 years ago Closed 26 years ago

(xpviewer only) resize of toolbars causes status bar to disappear/scrollbar to be split in half

Categories

(Core Graveyard :: Viewer App, defect, P1)

x86
Windows NT

Tracking

(Not tracked)

VERIFIED WONTFIX

People

(Reporter: ernie, Assigned: jevering)

Details

using the 11/23 build of seamonkey on NT40, if you minimize any of the toolbars it causes: 1) the status bar to disappear until the window is resized again. 2) the scrollbar to be split in half vertically.
Assignee: rickg → michaelp
Assignee: michaelp → rickg
looks like the webshell is being given bogus width and heigth values from some level above. bring up the xpviewer. go to the debug menu and "dump views." look at the dims of the top-level view. these are correct. close a toolbar. dump views again. the width and height have gotten inexplicably large (i.e. the views are trying to do the right thing, but the browser app is giving the webshell bad values - the values are suspiciously close to being the result of a call to GetBounds() rather than GetClientBounds()).
Summary: (xpviewer only) resize of toolbars causes status bar to disappear/scrollbar to be split in half → ss:(xpviewer only) resize of toolbars causes status bar to disappear/scrollbar to be split in half
Putting on ss: radar
Assignee: rickg → michaelp
Assignee: michaelp → rickg
Assignee: rickg → michaelp
Assignee: michaelp → rickg
ok, this is *NOT MY BUG*, but since there seems to be some insistence that i fix this, i've tracked it down to the xpfe's nsBrowserWindow calling the webshell's SetBounds() with incorrectly computed bounds. now, rather than JUST BLINDLY REASSINGING THIS BUG BACK TO ME, maybe it would be a good idea, to FIND SOMEONE WHO ACTUALLY KNOWS HOW THESE CALCULATIONS ARE SUPPOSED TO WORK and have them fix it.
Taking off ss: list per bug mtg today.
Summary: ss:(xpviewer only) resize of toolbars causes status bar to disappear/scrollbar to be split in half → (xpviewer only) resize of toolbars causes status bar to disappear/scrollbar to be split in half
Jim -- I'm handing these off to you. Good luck.
Here is a fix for this bug. Replace the routine: nsBrowserWindow::NotifyToolbarManagerChangedSize with the following: //---------------------------------------------------- NS_METHOD nsBrowserWindow::NotifyToolbarManagerChangedSize(nsIToolbarManager* aToolbarMgr) { nsRect rect; mWindow->GetClientBounds(rect); Layout(rect.width, rect.height); return NS_OK; }
Disregard the last message. I have now uploaded a patch file to: http://www.geocities.com/SiliconValley/Haven/8120/xpfe_diff.txt which includes this fix, and some other changes the same class which improve the handling of files in the Open dialog box on the file menu.
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → WONTFIX
I've been tasked with closing all xpviewer bugs, as it is 'dead'.
Status: RESOLVED → VERIFIED
Marking as Verified/Won't Fix due to different code base. (Minimize functionality currently not present in 2.1.99 builds; checked apprunner.) Ernie, please re-open if ya disagree and want it kept open; thanks!
*** Bug 55257 has been marked as a duplicate of this bug. ***
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.