Closed
Bug 1544
Opened 26 years ago
Closed 26 years ago
(xpviewer only) resize of toolbars causes status bar to disappear/scrollbar to be split in half
Categories
(Core Graveyard :: Viewer App, defect, P1)
Tracking
(Not tracked)
VERIFIED
WONTFIX
People
(Reporter: ernie, Assigned: jevering)
Details
using the 11/23 build of seamonkey on NT40, if you
minimize any of the toolbars it causes:
1) the status bar to disappear until the window is
resized again.
2) the scrollbar to be split in half vertically.
looks like the webshell is being given bogus width and heigth values from some
level above.
bring up the xpviewer.
go to the debug menu and "dump views."
look at the dims of the top-level view. these are correct.
close a toolbar.
dump views again.
the width and height have gotten inexplicably large (i.e. the views are trying
to do the right thing, but the browser app is giving the webshell bad values
- the values are suspiciously close to being the result of a call to
GetBounds() rather than GetClientBounds()).
Summary: (xpviewer only) resize of toolbars causes status bar to disappear/scrollbar to be split in half → ss:(xpviewer only) resize of toolbars causes status bar to disappear/scrollbar to be split in half
ok, this is *NOT MY BUG*, but since there seems to be some insistence that i
fix this, i've tracked it down to the xpfe's nsBrowserWindow calling the
webshell's SetBounds() with incorrectly computed bounds. now, rather than JUST
BLINDLY REASSINGING THIS BUG BACK TO ME, maybe it would be a good idea, to FIND
SOMEONE WHO ACTUALLY KNOWS HOW THESE CALCULATIONS ARE SUPPOSED TO WORK and
have them fix it.
Taking off ss: list per bug mtg today.
Summary: ss:(xpviewer only) resize of toolbars causes status bar to disappear/scrollbar to be split in half → (xpviewer only) resize of toolbars causes status bar to disappear/scrollbar to be split in half
Comment 6•26 years ago
|
||
Here is a fix for this bug. Replace the routine:
nsBrowserWindow::NotifyToolbarManagerChangedSize
with the following:
//----------------------------------------------------
NS_METHOD
nsBrowserWindow::NotifyToolbarManagerChangedSize(nsIToolbarManager* aToolbarMgr)
{
nsRect rect;
mWindow->GetClientBounds(rect);
Layout(rect.width, rect.height);
return NS_OK;
}
Comment 7•26 years ago
|
||
Disregard the last message. I have now uploaded a patch file to:
http://www.geocities.com/SiliconValley/Haven/8120/xpfe_diff.txt
which includes this fix, and some other changes the same class which improve the
handling of files in the Open dialog box on the file menu.
Updated•26 years ago
|
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → WONTFIX
Comment 8•26 years ago
|
||
I've been tasked with closing all xpviewer bugs, as it is 'dead'.
Updated•26 years ago
|
Status: RESOLVED → VERIFIED
Comment 9•26 years ago
|
||
Marking as Verified/Won't Fix due to different code base. (Minimize functionality
currently not present in 2.1.99 builds; checked apprunner.)
Ernie, please re-open if ya disagree and want it kept open; thanks!
Comment 10•24 years ago
|
||
*** Bug 55257 has been marked as a duplicate of this bug. ***
Updated•16 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•