Closed Bug 16189 Opened 25 years ago Closed 25 years ago

Undo/Redo is disabled again

Categories

(SeaMonkey :: MailNews: Message Display, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: fenella, Assigned: hangas)

References

Details

Linux (1999-10-11-14-M11) Commercial Win32 (1999-10-11-15-M11) Commercial Mac (1999-10-11-14-M11) Mozilla 1. Launch Messenger 2. Select an account (either POP or IMAP, click on the Inbox 3. Select a message and delete it. 4. Select the Edit menu Actual result: The Undo/Redo submenus are gray out. This used to work in M10 Expected result: I expected Undo/Redo to be enabled. It worked in M10 This occurs on all 3 platforms.
Assignee: phil → hangas
Reassign to hangas, cc jefft
Status: NEW → ASSIGNED
The command updating code was broken yesterday. Waterson reports that he has fixed it but is unable to confirm. I will try to confirm on today's build.
Component: Back End → Front End
Target Milestone: M11
I'd hold M11 for this to work as well as it did in M10, even if that means disconnecting command updating/dispatching until it works.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
The UI has been fixed to have undo and redo enabled in the menu when the thread pane has focus. Marking this bug fixed. However, this uncovered the fact that undo was broken, so I am filing a new bug against jefft to fix undo.
Paul, I just pulled your fix and it seems not working for Windows.
Status: RESOLVED → REOPENED
I am reopening this bug because it doesn't work for both Windows and Linux. The undo/redo remains disabled even after selecting a message in a thread pane.
Resolution: FIXED → ---
Status: REOPENED → ASSIGNED
Depends on: 17848
Now the Mac is working but 17848 is blocking Windows from working.
Blocks: 17928
Status: ASSIGNED → RESOLVED
Closed: 25 years ago25 years ago
Resolution: --- → FIXED
This is fixed. A "hack" has been put back into the JS controller to always enable undo/redo when the thread pane is selected.
Status: RESOLVED → REOPENED
Linux (1999-11-08-08 M11) Commercial Win_nt 4.0 (1999-11-08-09 M11) Commercial The undo/Redo is still disabled on Linux and Win_nt 4.0. But Mac's undo/redo is fixed. Re-open the bug
Resolution: FIXED → ---
Status: REOPENED → ASSIGNED
Yikes. Regression city. Well it may be too risky to fix this right at this point in the game. Preparing another hack. Stay tuned...
Here is more observations: POP/IMAP on Linux and Win_nt 4.0 1. Select a message, click on the Delete button, message is deleted. 2. set focus on the thread pane 3. select the Edit menu, I see that both Undo/redo is bolded 4. Select undo, the deleted message does not come up. It was deleted. This means Undo does not work properly. Mac: Imap/POP 1. Select a message, click on the Delete button, message is deleted 2. set focus on the thread pane 3. select the Edit menu, I see that both Undo/redo is bolded 4. Select undo, message re-appears. 5. Select redo, message is deleted again. Mac undo.redo works fine. POP/IMAP: Using the same scenario for Move/Copy message, Linux and Win_nt Undo/Redo do not work (it is bolded though) For Mac works, undo/redo works for POP and IMAP
Status: ASSIGNED → RESOLVED
Closed: 25 years ago25 years ago
Resolution: --- → FIXED
Hack to get around fact that menus are stealing focus from tree when clicked has been checked in.
QA Contact: lchiang → fenella
Status: RESOLVED → VERIFIED
Linux Redhat 6.0 (1999-11-10-17 M11) Win_nt 4.0 (1999-11-10-17 M11) POP/IMAP; Undo/Redo works fine on Delete/Copy/Move now on both Linux and Win Nt.
Based on the report from the basic functional test build (1999-11-10-17 M11), POP/IMAP: Undo/Redo of the Delete/Copy/Move failed. But I restested it on Linux Redhat 6.0 using (1999-11-15-20 M11) build. POP/IMAP: Undo/Redo of Delete/Copy/Move Passed.
Suzanne, you asked me to re-check this bug because you saw some problem in the 2/09 builds. Here is the result using the following builds. Linux (2000-02-11-11 M14) Win (2000-02-11-09 M14) Mac (2000-02-11-12 M14) undo/redo works fine in all platforms after Delete/Copy/Move in both POP and IMAP. However, there is another problem in Mac. See bug 27468.
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.