Closed Bug 1627 Opened 26 years ago Closed 26 years ago

Still leaks in xpviewer and viewer on win95

Categories

(Core :: Layout, defect, P2)

x86
Windows 95
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: paulmac, Assigned: michaelp)

Details

There are still leaks in rendering using the latest builds from 11/24. As I traverse the top100, I usually run out of resources around site 25 or 30. Somewhere on the order of a couple hundred Kb per page load. As noted in a previous bug, the resize leaks are gone. Not sure if it's a stop ship or not - I'll leave it up to the developer - sorry I don't know who does what so assigning it to michaelp.
Summary: Still leaks in xpviewer and viewer on win95 → ss: Still leaks in xpviewer and viewer on win95
Marking stop ship as this is starting to get annoying and jevering said it was a borderline stop ship. I'll let the smart people decide. Basically, I lose about 1% of my resources on each page load. I have 80Mb on my machine. This is win95 on 11/24 builds of viewer and xpviewer.
Status: NEW → ASSIGNED
made a number of changes that greatly improve the situation. i can now go through the top 100 on win95 without incident. need to get latest version of bounds checker to finish.
Regarding your need for latest Bounds Checker: I have the latest version of BC on my office computer. It runs on Win95/Win98/WinNT. The installation image can be found on \\buster\temp\download\bc503_s.exe. I don't remember if you need a reg number to load it. If so, you'll have to wait until somebody goes into the office and get's it for you. The reg is in Matt Sulivan's office. We have only 1 license that I know of, and I want to be sure we stay legal with it.
i've confirmed that the remaining resource usage issues are related to caching too many fonts. flushing the font cache between documents brings our resource usage to be on par with nav 4.5. it appears that there are also a few cases where nsIImage objects are being released by layout objects, so fixing that will further improve things.
Summary: ss: Still leaks in xpviewer and viewer on win95 → Still leaks in xpviewer and viewer on win95
This is looking as good as we can get for this release. Taking off ss: list. paulmac, let us know how this looks with Nov 28 build just as an FYI on how much better it has gotten and any other comments you may have.
Summary: Still leaks in xpviewer and viewer on win95 → rn: Still leaks in xpviewer and viewer on win95
Looks marginally better in 11/28 build. Michael, I assume your font cache flushing fix is *not* in this build? It's unclear in your comment. I still see my resources drop precipitously, in contrast to Nav. 4.5. I'm okay with this not being a stop ship, though perhaps it should be release noted.
Summary: rn: Still leaks in xpviewer and viewer on win95 → Still leaks in xpviewer and viewer on win95
Memory leaks will not be included in Release Notes for this build. Taking off rn: radar.
correct. my font cache change is *not* in. if there is going to be a re-spin, i could put it in though. you're right, without this fix resources definitely get eaten up quickly, but at least we can now go through the top 100 instead of the top 25 :).
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
i've checked in my font cache change. all should be well.
Status: RESOLVED → VERIFIED
No longer seeing big leaks, marking verified.
You need to log in before you can comment on or make changes to this bug.