Closed Bug 16578 Opened 25 years ago Closed 25 years ago

[DOGFOOD]nytimes hangs on viewer

Categories

(Core :: DOM: HTML Parser, defect, P3)

Product:
Core
Component:
DOM: HTML Parser
Platform:
Other
Other
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: mcafee, Assigned: harishd)

References

(
URL
)

Details

(Whiteboard: [PDT+])

linux, viewer & apprunner. visit URL, hangs. morse thinks this is hanging in the parser.?
Regression in Friday evening's tree (this worked fine in Thursday's tree). Go to http://nytimes.com. Browser hangs before page ever comes up. I broke execution and obtain the stack trace shown below. Furthermore, by stepping through it, I see that it is stuck in the do loop in CNavDTD::HandleDefaultStartToken (CNavTDT.cpp). ::Append(unsigned short 99) line 1106 + 14 bytes CNavDTD::BackwardPropagate(nsString & {...}, nsHTMLTag eHTMLTag_userdefined, nsHTMLTag eHTMLTag_tbody) line 2051 CNavDTD::CreateContextStackFor(nsHTMLTag eHTMLTag_tr) line 2985 + 35 bytes CNavDTD::HandleDefaultStartToken(CToken * 0x02800530, nsHTMLTag eHTMLTag_tr, nsIParserNode & {...}) line 978 CNavDTD::HandleStartToken(CToken * 0x02800530) line 1269 + 22 bytes CNavDTD::HandleToken(CNavDTD * const 0x02bdf930, CToken * 0x02800530, nsIParser * 0x02bfd810) line 653 + 12 bytes CNavDTD::BuildModel(CNavDTD * const 0x02bdf930, nsIParser * 0x02bfd810, nsITokenizer * 0x02bde830, nsITokenObserver * 0x00000000, nsIContentSink * 0x02bebdf0) line 457 + 20 bytes nsParser::BuildModel() line 1038 + 34 bytes nsParser::ResumeParse(nsIDTD * 0x00000000, int 0) line 949 + 11 bytes nsParser::OnDataAvailable(nsParser * const 0x02bfd814, nsIChannel * 0x02bf9db0, nsISupports * 0x00000000, nsIInputStream * 0x02bfd758, unsigned int 0, unsigned int 4190) line 1376 + 19 bytes nsDocumentBindInfo::OnDataAvailable(nsDocumentBindInfo * const 0x02bf9f00, nsIChannel * 0x02bf9db0, nsISupports * 0x00000000, nsIInputStream * 0x02bfd758, unsigned int 0, unsigned int 4190) line 1198 + 32 bytes nsChannelListener::OnDataAvailable(nsChannelListener * const 0x02bf9c50, nsIChannel * 0x02bf9db0, nsISupports * 0x00000000, nsIInputStream * 0x02bfd758, unsigned int 0, unsigned int 4190) line 1384 nsHTTPResponseListener::OnDataAvailable(nsHTTPResponseListener * const 0x02bfb150, nsIChannel * 0x02bfe750, nsISupports * 0x02bf9db0, nsIInputStream * 0x02bfd758, unsigned int 32064, unsigned int 4190) line 186 + 47 bytes nsOnDataAvailableEvent::HandleEvent(nsOnDataAvailableEvent * const 0x02aaa7a0) line 369 nsStreamListenerEvent::HandlePLEvent(PLEvent * 0x02aaa750) line 164 + 12 bytes PL_HandleEvent(PLEvent * 0x02aaa750) line 534 + 10 bytes PL_ProcessPendingEvents(PLEventQueue * 0x00d0efd0) line 493 + 9 bytes _md_EventReceiverProc(HWND__ * 0x0828024a, unsigned int 49345, unsigned int 0, long 13692880) line 963 + 9 bytes USER32! 77e71268() 00d0efd0()
Blocks: 16258
See comments in 16258. nytimes.com was a test site for that bug and, because of this bug, we can no longer test that 16258 is fixed for nytimes. Had to use an alternate site that was also showing the problem in order to determine that 16258 was fixed.
Assignee: rickg → harishd
Harish: it looks like the user-defined tag is causing this. Please take a look. If you're swamped, sent it back to me and I'll fix it.
Summary: nytimes hangs on viewer → [DOGFOOD]nytimes hangs on viewer
Also hangs in 1999-10-15-11-M11 on Windows NT, after the body background comes up, but before anything else appears. This message appeared on the console: FindShortcut: in='http://www.nytimes.com' out='null' After that, the process needed to be killed.
As rickg mentioned, the problem was with the user defined tag. Here is a reduced case that will cause mozilla to hang. <HTML> <BODY> <NYT_FOOTER version="1.0" type="index"> <tr> <td bgcolor=red> hello </BODY> </HTML> I've backed out my change ( will work on it later). The URL should load fine now. However, yesterday's build ( after backing out my change) crashes with the following trace: nsDebug::PreCondition(char * 0x01f88914, char * 0x01f88908, char * 0x01f888d4, int 378) line 262 + 13 bytes nsJISx4501LineBreaker::Next(nsJISx4501LineBreaker * const 0x0120efe0, unsigned short * 0x01262980, unsigned int 2, unsigned int 2, unsigned int * 0x0012bb24, int * 0x0012bb30) line 378 + 34 bytes nsTextTransformer::GetNextWord(int 0, int & 1, int & 1, int & 1, int 1) line 241 + 38 bytes nsTextFrame::Reflow(nsTextFrame * const 0x01212ef4, nsIPresContext & {...}, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0) line 2662 + 38 bytes nsLineLayout::ReflowFrame(nsIFrame * 0x01212ef0, nsIFrame * * 0x0012bf80, unsigned int & 0) line 910 nsInlineFrame::ReflowInlineFrame(nsIPresContext * 0x011ebdb0, const nsHTMLReflowState & {...}, nsInlineFrame::InlineReflowState & {...}, nsIFrame * 0x01212ef0, unsigned int & 0) line 1553 + 20 bytes nsInlineFrame::ReflowInlineFrames(nsIPresContext * 0x011ebdb0, const nsHTMLReflowState & {...}, nsInlineFrame::InlineReflowState & {...}, nsHTMLReflowMetrics & {...}, unsigned int & 0) line 1400 + 28 bytes nsInlineFrame::Reflow(nsInlineFrame * const 0x012107c4, nsIPresContext & {...}, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0) line 1316 + 31 bytes nsLineLayout::ReflowFrame(nsIFrame * 0x012107c0, nsIFrame * * 0x0012cb84, unsigned int & 0) line 910 nsBlockFrame::ReflowInlineFrame(nsBlockReflowState & {...}, nsLineLayout & {...}, nsLineBox * 0x01290ad0, nsIFrame * 0x012107c0, unsigned char * 0x0012c148) line 3563 + 26 bytes nsBlockFrame::DoReflowInlineFrames(nsBlockReflowState & {...}, nsLineLayout & {...}, nsLineBox * 0x01290ad0, int * 0x0012ca58, unsigned char * 0x0012c8ec) line 3454 + 28 bytes nsBlockFrame::DoReflowInlineFramesAuto(nsBlockReflowState & {...}, nsLineBox * 0x01290ad0, int * 0x0012ca58, unsigned char * 0x0012c8ec) line 3400 + 34 bytes nsBlockFrame::ReflowInlineFrames(nsBlockReflowState & {...}, nsLineBox * 0x01290ad0, int * 0x0012ca58) line 3348 + 24 bytes nsBlockFrame::ReflowLine(nsBlockReflowState & {...}, nsLineBox * 0x01290ad0, int * 0x0012ca58, int 0) line 2560 + 20 bytes nsBlockFrame::ReflowDirtyLines(nsBlockReflowState & {...}) line 2320 + 27 bytes nsBlockFrame::Reflow(nsBlockFrame * const 0x01282494, nsIPresContext & {...}, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0) line 1415 + 18 bytes nsBlockReflowContext::ReflowBlock(nsIFrame * 0x01282490, const nsRect & {...}, int 1, int 240, int 0, nsMargin & {...}, unsigned int & 0) line 229 + 42 bytes nsBlockFrame::ReflowBlockFrame(nsBlockReflowState & {...}, nsLineBox * 0x01283570, int * 0x0012d12c) line 3136 + 59 bytes This appears to be a separate bug. Note: http://linuxmafia.com/refund/japan also crashes with the same trace with or without my change. So, this ought to be a different bug. Leaving the bug open.
Status: NEW → ASSIGNED
Whiteboard: [PDT+]
Whiteboard: [PDT+] → [PDT ]
This looks like it's working on linux.
Whiteboard: [PDT ] → [PDT+]
Blocks: 16950
The above URL neither hangs nor crashes. Is this still a DOGFOOD??
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
looks like harishd has ? fixed this. Marking fixed. This works for me.
Yep, it's working fine for me as well. Still can't log onto the nytimes webpage but that's a different problem, namely bug 16258, which I'm investigating.
Target Milestone: M12
Putting on M12 radar since fixed during this time.
works for me too, marking verified.
Status: RESOLVED → VERIFIED
verified
You need to log in before you can comment on or make changes to this bug.