Closed
Bug 1663
Opened 26 years ago
Closed 22 years ago
string usage inconsistent between DOM and XPIDL
Categories
(Core :: DOM: Core & HTML, defect, P2)
Tracking
()
RESOLVED
FIXED
People
(Reporter: peterl-retired, Assigned: scc)
References
Details
(Keywords: dom1)
in use of pointers versus references for out paramaters. We need to pick a
standard and use it.
Also, get methods could/should be made const. (We may need to override this for
certain methods.)
Updated•26 years ago
|
Status: NEW → ASSIGNED
Comment 2•26 years ago
|
||
per leger, assigning QA contacts to all open bugs without QA contacts according
to list at http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser
Updated•26 years ago
|
Target Milestone: M4 → M6
Updated•26 years ago
|
Target Milestone: M6 → M8
Comment 3•26 years ago
|
||
I know, I know. I need to deal with this sooner rather than later. Still pushing
off till M8.
Should also look into switching over to using nsIString.
Updated•26 years ago
|
Target Milestone: M8 → M10
Comment 4•26 years ago
|
||
I'm not happy with the way things are going with the wstring/nsIString debate. I
still want that issue to be better resolved.
Assignee: vidur → brendan
Status: ASSIGNED → NEW
Target Milestone: M10 → M11
Brendan and vidur are doing the ``[shared] wstring'' surgery on the DOM
interfaces, so I'm giving this to brendan.
Updated•25 years ago
|
Target Milestone: M11 → M12
Comment 6•25 years ago
|
||
Balancing my M-numbers.
/be
Updated•25 years ago
|
Target Milestone: M12 → M14
Comment 7•25 years ago
|
||
After beta.
/be
Updated•25 years ago
|
Target Milestone: M14 → M16
Comment 8•25 years ago
|
||
Pushing to after beta, for sure.
/be
Comment 9•25 years ago
|
||
Scott, can I give this bug to you for keeping and possibly fixing while I'm on
sabbatical? Vidur and I haven't done the [shared] evil yet. Cc'ing vidur and
waterson.
/be
Assignee: brendan → scc
Status: ASSIGNED → NEW
Summary: IDL generated interfaces inconsistent → string usage inconsistent between DOM and XPIDL
Comment 11•25 years ago
|
||
Hmmm. Well, the new string interfaces are going to make it easy and pleasant to
use just a |char*| or a |PRUnichar*| as a interface type for crossing [XP]COM
boundaries. Essentially, the thing that was |nsXPIDL[C]String| will be a full
member of the string hierarchy and useable in the same way that |nsString| is.
So my recommendation for passing strings across boundaries is to use raw
pointers but then in C++ code, collect them into (the new equivalent of) an
|nsXPIDL[C]String|. I think this is the best of both worlds ... compatibility
and functionality.
Comment 12•25 years ago
|
||
With respect to the initial description: I think the general decision has been
pointers for out-parameters, and though some people are still using non-|const|
references, we are gradually weeding them out. Similarly with marking all
getters |const|. I assume you are not just talking about strings here, but the
app as whole.
Updated•25 years ago
|
Target Milestone: M16 → M18
Comment 13•25 years ago
|
||
mass re-assigning to my new bugzilla account
Assignee: scc → scc
Status: ASSIGNED → NEW
Assignee | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 14•25 years ago
|
||
Moving up based on the `new porkjockey's' architecture meeting.
Target Milestone: M18 → M17
Updated•24 years ago
|
QA Contact: gerardok → janc
Comment 15•24 years ago
|
||
Mass update of qa contact
Assignee | ||
Updated•24 years ago
|
Target Milestone: M17 → ---
Updated•24 years ago
|
Component: DOM Level 1 → DOM Core
Assignee | ||
Comment 18•22 years ago
|
||
closing this bug because I think it no longer applies. The string scheme for
the DOM is in place and there are no recent complaints.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Component: DOM: Core → DOM: Core & HTML
QA Contact: stummala → general
You need to log in
before you can comment on or make changes to this bug.
Description
•