add a windows hook to detect when a plugin subclasses a window so we can add a try/catch

Taking. Marking dependency on bug 132759 as subclassing will be added there. I am not sure I fully understand this bug. I am going to add try/catch aroung plugin winproc call in bug 132759. Do we need anything beyond that?

the issue was to also catch situations where the plugin creates child windows of our plugin window... we need to track the creation of new plugin 'child windows' and subclass them too... -- rick

Rick: could you give a snippet of what that code would look like (ask the Linux guy)?

assigning to AV

Marking topembed+ as per topembed triage.

I decided not to keep track of subclassed child windows, this allows to keep the code really simple.

should all the calls to SetWindow in nsPluginHostImpl.cpp be wrapped?

moving to 1.3 beta

per triage, topembed- and reassign to --->peterl

Comment on attachment 106810 [details] [diff] [review] patch v.1 this patch still needs some work: (a) There are cases of SetWindow that are missed in nsPluginHostImpl.cpp and this doesn't catch any windows created after SetWindow is called. (b) I think we need to subclass when a new window is made when we get the WM_CREATE message. This will ensure all newly created windows are also protected.