Closed
Bug 16925
Opened 25 years ago
Closed 22 years ago
[FEATURE] Want additional header options
Categories
(MailNews Core :: Composition, enhancement, P3)
MailNews Core
Composition
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: John_David_Galt, Assigned: bugzilla)
References
(Depends on 1 open bug)
Details
Attachments
(3 files, 5 obsolete files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
bugzilla
:
review+
bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
bugzilla
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
At a minimum I would like to be able to set these headers:
Approved:
Distribution:
Expires:
Keywords:
Supersedes:
X-No-Archive:
Some of these are not always allowed on posts, but I feel that enforcing that
is the server's job, not the client's.
Updated•25 years ago
|
Assignee: ducarroz → nobody
Summary: [FEATURE] Want additional header options when posting news → [HELP WANTED][FEATURE] Want additional header options when posting news
Whiteboard: [HELP WANTED]
Comment 1•25 years ago
|
||
Add to help wanted list
Assignee | ||
Comment 2•25 years ago
|
||
There is a way today to specify through the prefs a custom header but I don't remember which pref. Seth?
Comment 3•25 years ago
|
||
this feature sort of works.
for example, add this to your prefs.js:
user_pref("mail.compose.other.header","Approved");
a good help wanted bug would be to fix it so that worked like this:
user_pref("mail.compose.other.headers","Approved,Supersedes,Expires");
right now, you can only have one additional header at a time.
Comment 4•25 years ago
|
||
this feature sort of works.
for example, add this to your prefs.js:
user_pref("mail.compose.other.header","Approved");
a good help wanted bug would be to fix it so that worked like this:
user_pref("mail.compose.other.headers","Approved,Supersedes,Expires");
right now, you can only have one additional header at a time.
Comment 5•25 years ago
|
||
this feature sort of works.
for example, add this to your prefs.js:
user_pref("mail.compose.other.header","Approved");
a good help wanted bug would be to fix it so that worked like this:
user_pref("mail.compose.other.headers","Approved,Supersedes,Expires");
right now, you can only have one additional header at a time.
Comment 6•25 years ago
|
||
This is a small javascript hack. The code that needs changing is in
package/chrome/messengercompose/content/default/MsgComposeCommands.js
from the M10 package or a recent nightly build. Since the needed code
is part of the UI, its released with the binary so you can edit that
and don't need to pull an entire source tree.
http://lxr.mozilla.org/seamonkey/source/mailnews/compose/resources/content/MsgComposeCommands.js#280
if (other_header != "") {
var opt = new Option(other_header + ":", "addr_other");
selectNode.add(opt, null);
}
Updated•25 years ago
|
Keywords: helpwanted
Updated•25 years ago
|
Summary: [HELP WANTED][FEATURE] Want additional header options when posting news → [FEATURE] Want additional header options when posting news
Whiteboard: [HELP WANTED]
Comment 9•24 years ago
|
||
Widening scope to mail (not just news).
The feature seth and dawn spoke of regressed. Got it to work again. Attaching
patch.
Summary: [FEATURE] Want additional header options when posting news → [FEATURE] Want additional header options
Comment 10•24 years ago
|
||
Comment 11•24 years ago
|
||
Bug 61520 is related - it is about adding headers at identity setup time.
Comment 12•24 years ago
|
||
Superseding articles (and therefore use of the Supersedes: header) is the
subject of bug #11045.
Comment 13•23 years ago
|
||
*** Bug 56273 has been marked as a duplicate of this bug. ***
Comment 14•23 years ago
|
||
*** Bug 94395 has been marked as a duplicate of this bug. ***
Comment 15•23 years ago
|
||
*** Bug 116870 has been marked as a duplicate of this bug. ***
Comment 16•22 years ago
|
||
Added CC
Comment 17•22 years ago
|
||
abiltiy to support arbitrary header in mail/news, and turn off auto completion
for these
Comment 18•22 years ago
|
||
support arbitrary header in mail/news
abiltiy to support arbitrary header in mail/news.
feature is controlled by a new pref mail.compose.other.headers which takes
comma separated headers.
user_pref("mail.compose.other.headers","Approved,Supersedes,Expires")
this should probably have a default somewhere in the prefs section but I'm not
quite sure where that lives
Comment 19•22 years ago
|
||
patches are against 1.1a source.
keywords -> review patch??
Comment 21•22 years ago
|
||
first, you'll want to get a review from the compose window module owner,
ducarroz. I'll look at it after that.
Assignee | ||
Comment 22•22 years ago
|
||
Comment on attachment 88964 [details] [diff] [review]
support arbitrary header in mail/news, part 1 of 2
Looks good. R=ducarroz
Attachment #88964 -
Flags: review+
Assignee | ||
Updated•22 years ago
|
Attachment #88964 -
Attachment description: support arbitrary header in mail/news → support arbitrary header in mail/news, part 1 of 2
Assignee | ||
Comment 23•22 years ago
|
||
Comment on attachment 88965 [details] [diff] [review]
support arbitrary header in mail/news, part 2 of 2
Looks good. R=ducarroz
Attachment #88965 -
Attachment description: support arbitrary header in mail/news → support arbitrary header in mail/news, part 2 of 2
Attachment #88965 -
Flags: review+
Comment 24•22 years ago
|
||
can you attach unified diffs? cvs diff -uw ? they're easier to read
Comment 25•22 years ago
|
||
unified patch.
(sorry not from cvs - its taking an etirnity to do make -f client.mk)
Attachment #88964 -
Attachment is obsolete: true
Comment 27•22 years ago
|
||
should give some credit to neil@parkwaycc.co.uk as this patch incorporates a
patch for bug 151223
Comment 28•22 years ago
|
||
Comment on attachment 89464 [details] [diff] [review]
support arbitrary header in mail/news, unified patch part 1 of 2
sr=bienvenu, and carrying over r=
Attachment #89464 -
Flags: superreview+
Attachment #89464 -
Flags: review+
Comment 29•22 years ago
|
||
Comment on attachment 89466 [details] [diff] [review]
support arbitrary header in mail/news, unified patch part 2 of 2
sr=bienvenu, and carrying over r=. Thx for the patch.
Attachment #89466 -
Flags: superreview+
Attachment #89466 -
Flags: review+
Comment 30•22 years ago
|
||
Yes, thanks from me, too! :-)
Comment 31•22 years ago
|
||
nice to be able to give a little back for once ;-)
(who wants to check this in on the correct branch(es)/trunk?)
Comment 32•22 years ago
|
||
I'd suggest getting this into the trunk, but not the branch.
QA Contact: lchiang → gayatri
Updated•22 years ago
|
QA Contact: gayatri → laurel
Comment 33•22 years ago
|
||
ducarroz (someone!) can you commit this patch?
Would be nice to start using the nightlies again ;-)
Updated•22 years ago
|
Status: NEW → ASSIGNED
Comment 34•22 years ago
|
||
*** Bug 155742 has been marked as a duplicate of this bug. ***
Comment 35•22 years ago
|
||
*** Bug 110091 has been marked as a duplicate of this bug. ***
Comment 36•22 years ago
|
||
The 2 parts of unified patch were not directly applicable on linux due to the
backslashes. I just merged the two parts and adapted it so it runs in linux
(patch -p1).
Note for people using the patches. Although it is stated in the bug messages I
overlooked it. So take note and don't repeat my mistake:
**************************************
******the relevant entry in prefs.js changes from ...header to ...headers *****
**************************************
Assignee | ||
Comment 37•22 years ago
|
||
This patch you can apply against a current trunk tree...
Attachment #89464 -
Attachment is obsolete: true
Attachment #89466 -
Attachment is obsolete: true
Attachment #90304 -
Attachment is obsolete: true
Assignee | ||
Comment 38•22 years ago
|
||
Comment on attachment 90508 [details] [diff] [review]
same patch but diff agains a current trunk tree
Carry over R= and SR=
Attachment #90508 -
Flags: superreview+
Attachment #90508 -
Flags: review+
Comment 39•22 years ago
|
||
Just so people notice the user pref is back to "mail.compose.other.header" ;-)
Assignee | ||
Comment 40•22 years ago
|
||
Fix checked in the trunk
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 41•22 years ago
|
||
Just nitpicking but this code's reuse of bad existing code makes it worse.
My particular nit concerns calling document.getElementById in a loop, but I
would also like to point out that menulists have an appendItem(label, value) method.
Comment 42•22 years ago
|
||
Assignee | ||
Comment 43•22 years ago
|
||
I reopen the bug in order to use the new patch...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 45•22 years ago
|
||
It's probably just me, but looking at the patches I can't see how you add a
value to the arbitrary headers. For instance, if I want X-No-Archive: True, how
do I get the "true" in there?
Comment 46•22 years ago
|
||
Jerry,
you set the value for the headers in the compose window, just as you would for a
To or a Cc header.
Comment 47•22 years ago
|
||
By the way:
We have the pref "mailnews.customHeaders" which can contain a header field list
for searching etc., like "Message-ID: Newsgroups: Supersedes:".
Here, we now have the pref "mail.compose.other.header" which takes a
comma-separated list of such header fields, like "X-No-Archive,Expires".
I suggest to unify these two list formats.
And it would be nice to be able to add default values for this user fields...
Comment 48•22 years ago
|
||
Re-assigning to Jean-Francois Ducarroz as I don't have checkin privs, and my
work is done here ;-)
Assignee: teilo+bugzilla → ducarroz
Status: REOPENED → NEW
Assignee | ||
Updated•22 years ago
|
Whiteboard: have fix
Assignee | ||
Comment 49•22 years ago
|
||
Comment on attachment 90928 [details] [diff] [review]
Patch to move document.getElementById out of the loop and use selectNode.appendItem
Works great, R=ducarroz
Attachment #90928 -
Flags: review+
Comment 50•22 years ago
|
||
Comment on attachment 90928 [details] [diff] [review]
Patch to move document.getElementById out of the loop and use selectNode.appendItem
sr=bienvenu
Attachment #90928 -
Flags: superreview+
Comment 51•22 years ago
|
||
Patch was checked in by timeless.
Status: NEW → RESOLVED
Closed: 22 years ago → 22 years ago
Resolution: --- → FIXED
Comment 52•22 years ago
|
||
*** Bug 165069 has been marked as a duplicate of this bug. ***
Comment 54•20 years ago
|
||
Is this feature in Thunderbird yet?
Updated•20 years ago
|
Product: MailNews → Core
Comment 55•19 years ago
|
||
Still doesn't work in TB 1.5.0.2.
Comment 56•18 years ago
|
||
> Is this feature in Thunderbird yet?
yes
>Still doesn't work in TB 1.5.0.2.
yes it does
edit prefs.js add user_pref("mail.compose.other.header","Approved,Supersedes,Expires,Wibble,Whatever");
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•