Closed Bug 1742 Opened 26 years ago Closed 26 years ago

NGLayout hangs forever on nsIURL::Read() if file doesn't exist

Categories

(Core :: Networking: File, defect, P2)

x86
Windows NT
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: jst, Assigned: gagan)

References

Details

(Keywords: testcase)

nsIURL *url; NS_NewURL(url, "file://C:/foo.bar"); url->Open(...) url->Read(...) hangs on Read() if the file C:\foo.bar doesn't exist. This patch fixes the problem... diff -cr --exclude .obj nglayout-orig/mozilla/network/module/nsNetService.cpp vmproj/mozilla/network/module/nsNetService.cpp *** nglayout-orig/mozilla/network/module/nsNetService.cpp Tue Nov 24 13:18:50 1998 --- vmproj/mozilla/network/module/nsNetService.cpp Thu Dec 03 00:08:25 1998 *************** *** 491,500 **** #endif /* TIMEBOMB_ON */ /* Start the URL load... */ ! NET_GetURL (URL_s, /* URL_Struct */ ! FO_CACHE_AND_NGLAYOUT, /* FO_Present_type */ ! (MWContext *) stubContext, /* MWContext */ ! bam_exit_routine); /* Exit routine... */ /* Remember, the URL_s may have been freed ! */ --- 491,503 ---- #endif /* TIMEBOMB_ON */ /* Start the URL load... */ ! int ret = NET_GetURL (URL_s, /* URL_Struct */ ! FO_CACHE_AND_NGLAYOUT, /* FO_Present_type */ ! (MWContext *) stubContext, /* MWContext */ ! bam_exit_routine); /* Exit routine... */ ! ! if (ret < 0) ! goto loser; /* Remember, the URL_s may have been freed ! */
Status: NEW → ASSIGNED
Setting all current Open Critical and Major to M3
setting paulmac as QA contact for all gagan's bugs (sorry for the spam)
Assignee: gagan → spence
Status: ASSIGNED → NEW
Spence could you see if this is still happens and if so fix it in the tip for dogfood.
*** Bug 1744 has been marked as a duplicate of this bug. ***
Status: NEW → ASSIGNED
Assignee: spence → gagan
Status: ASSIGNED → NEW
Taking over...
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Fixed for now. This needs revisiting, since there is a bigger bug about file:// urls in general.
Status: RESOLVED → VERIFIED
verified that it no longer hangs forever on invalid local file.
Changing all Networking Library/Browser bugs to Networking-Core component for Browser. Occasionally, Bugzilla will burp and cause Verified bugs to reopen when I do this in a bulk change. If this happens, I will fix. ;-)
Bulk move of all Networking-Core (to be deleted component) bugs to new Networking component.
Keywords: testcase
Component: Networking → Networking: File
You need to log in before you can comment on or make changes to this bug.