Closed
Bug 18016
Opened 25 years ago
Closed 25 years ago
[FTP] failed to download and save file with ftp
Categories
(Core :: Networking, defect, P3)
Tracking
()
VERIFIED
FIXED
M12
People
(Reporter: sspitzer, Assigned: law)
Details
Attachments
(1 file)
(deleted),
image/gif
|
Details |
I tried to use mozilla to get a daily build from ftp.mozilla.org
I got as far as the saving file dialog, but it never progressed.
I got stuck at 0%.
I'll attach the screen shot of the dialog at where it stopped.
Reporter | ||
Comment 1•25 years ago
|
||
Updated•25 years ago
|
Assignee: valeski → law
Comment 2•25 years ago
|
||
FTP is downloading the data (check for the file after hitting cancel on the
dialog (after you think it's done ;). It's just not propagating status. Bill,
where does your dialog get progress info?
Reporter | ||
Comment 3•25 years ago
|
||
jud is right. the file appeared to be download. I save it as foo.tar.gz
ls -al foo.tar.gz
-rwx------ 1 seth seth 5203264 Nov 4 12:13 foo.tar.gz
the progress never changed and it never went away, when it finished.
but it looks like it did download the whole beast!
file download is being overhauled to deal with the Necko-ized world properly.
This code was written to the old netlib notification mechanism
(nsIStreamListener, I think). The OnProgress notifications now go out to the
nsIProgressEventSink. This was added as a base class to the nsStreamXferOp
class but unfortunately, there's no nsIEventSinkGetter that will return this
progress event sink.
Actually, it's even worse. When this code is overhauled to be fully necko-fied,
it won't even be doing the channel creation (at which point one can provide an
event sink getter). There are further obstacles to putting in place the
"correct" implementation (namely, the inability to obtain an input stream from
an http channel). It's also not clear if passing the input stream to AsyncWrite
will be possible while still getting the OnProgress.
Anyway, the current implementation I'm working on (much more like the ultimate
solution but with workarounds for the current obstacles) manages progress
notifications by simulating them from the stream listener's OnDataAvailable.
I'm still battling two problems:
1. saving files coming via ftp doesn't work right. I diagnosed one problem; was
due to ftp passing a proxy channel to OnStartRequest/OnStopRequest, which threw
off my code (I was expecting the same channel I did the AsyncRead on). But it's
still hanging.
2. leaking; my object gets referenced from both the input and output
channels/streams and something is not letting go; may be proxy related.
ftp download in general is tracked by bug #10737 so I'm making this one a
duplicate of that.
*** This bug has been marked as a duplicate of 10737 ***
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → DUPLICATE
Updated•25 years ago
|
Status: RESOLVED → REOPENED
Comment 6•25 years ago
|
||
I don't think of this bug as a duplicate of that. Bug 10737 means get basic ftp
support working. This bug is really unrelated to ftp. I think you have the exact
same problems trying to save http, file, etc. links, right?
Status: REOPENED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
The dialog is now showing progress and completion (modulo other bugs).
Comment 10•25 years ago
|
||
Bulk move of all Necko (to be deleted component) bugs to new Networking
component.
Comment 11•25 years ago
|
||
old bug - FTP has been working for some time now
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•