Closed Bug 18036 Opened 25 years ago Closed 25 years ago

[DOGFOOD] arbitrary header in filter rule causes infinite loop in nsMsgSearchTerm.cpp

Categories

(MailNews Core :: Backend, defect, P3)

x86
All
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: sspitzer, Assigned: sspitzer)

Details

(Whiteboard: [PDT+])

Attachments

(1 file)

this prevent me from opening my Inbox, where that message lives. I'll attach the message next. I'm debugging now. come stop by to see the gory details.
Summary: [DOGFOOD] message causing infinite loop in nsMsgSearchTerm.cpp → [DOGFOOD] arbitrary header in filter rule causes infinite loop in nsMsgSearchTerm.cpp
updating summary to reflect the real problem. here's the rule that caused the problem: name="mail qa auto cvs update" enabled="yes" description="" type="1" action="Move to folder" actionValue="//imap:Trash" condition=" AND (\"Message-ID\",contains,worksforme.mcom.com)" in 4.x, on Linux at least, Message-ID was not one of the default header types to filter on, so I created it.
QA Contact: lchiang → laurel
the following patch fixes the problem. Index: src/nsMsgBodyHandler.cpp =================================================================== RCS file: /cvsroot/mozilla/mailnews/base/search/src/nsMsgBodyHandler.cpp,v retrieving revision 1.7 diff -r1.7 nsMsgBodyHandler.cpp 163a164,166 > else if (m_headersSize == 0) { > buf[0] = '\0'; > } 172d174 < char * line = NULL; (that second bit just removes a warning.)
stealing from david, as I'm about to check in the fix.
Assignee: bienvenu → sspitzer
Status: NEW → ASSIGNED
Target Milestone: M11
marking m11. accepting.
Whiteboard: [PDT+]
Putting on PDT+ radar.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
OK using: 1999-11-09-11m11 commercial build NT 4.0 1999-11-09-11m11 commercial build linux 6.0
Status: RESOLVED → VERIFIED
OK using 1999-11-08-08m11 commercial mac OS 8.5.1
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: