Closed Bug 18038 Opened 25 years ago Closed 25 years ago

[dogfood][webshell] Back/Forward buttons updated too early, partially loaded pages removed from SH

Categories

(SeaMonkey :: General, defect, P3)

x86
Windows NT
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: radha, Assigned: radha)

References

Details

(Whiteboard: [PDT-])

Back/forward buttons are updated before a page finishes loading, which sometimes misleads users about whether he can actually go back/forward. Update it after a page finishes loading.
Status: NEW → ASSIGNED
QA Contact: leger → claudius
Target Milestone: M11
Isn't this useful when you want to back through a number of pages without waiting for them all to (re)load? If the buttons aren't updated until the page has finished loading then what will the back button do if someone presses it part way through loading a page?
Target Milestone: M11 → M13
This wil be addressed the *right* way after the redesigned webshell and session history lands.
Target Milestone: M13 → M11
It's updating faster than one might think. Try going to a domain that doesn't exist. http://www.blahblah.ru/ Netscape 4.08 won't show a back button because you haven't left the page yet. Instead a popup appears that says something like No DNS entry... Using Mozilla (Build 1999110708), try clicking "File, Open Web Location" and type "www.blahblah.ru". Notice the url updated on the browser already and the buttons say you can go back. But you haven't left whatever page you were on first (I was on www.yahoo.com before, so it's still there.). So... The problem seems to be not that the button is updated before the page finishes loading, but it's updating before the page even begins loading...
Summary: Back/Forward buttons updated too early → [webshell] Back/Forward buttons updated too early
Target Milestone: M11 → M12
m12.
*** Bug 17430 has been marked as a duplicate of this bug. ***
Blocks: 18471
*** Bug 19351 has been marked as a duplicate of this bug. ***
This bug will address the problem on what gets into SH and what will not. ie., partially loaded pages will stay in SH, while unresolved pages won't. The new BrowserInstance along with new WebShell provides better ways of dealing with this.
Summary: [webshell] Back/Forward buttons updated too early → [dogfood][webshell] Back/Forward buttons updated too early
Whiteboard: [PDT-]
Seems like a low-risk problem. Ugly maybe... : )
Depends on: 18804
*** Bug 17517 has been marked as a duplicate of this bug. ***
Summary: [dogfood][webshell] Back/Forward buttons updated too early → [dogfood][webshell] Back/Forward buttons updated too early, partially loaded pages removed from SH
See also bug 19073, dealing with missing files (file:/// URLs). Also see my comments on bug 6882 (as I said on bug 17517).
Radha thinks she has a hack to fix this by M12. The real fix of implementing nsIStreanListener will come in M13. Leaving this open in M12 for the hack for now.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
I have commented out the piece of code in Session History that used to remove partially loaded pages and unresolved pages from SH. So, now partially loaded pages will stay in SH. So will unresolved pages. To fix this the right way, nsIBrowserInstance has to implement nsIStreamObserver and hook to OnDataAvailable(). This will be done after the new webshell is functional and Browser Instance has gone thro' its round of changes. I'm going to open a new bug for that and close this one out.
If you do open another bug please note it here. thanx.
I can verifiy that this is fixed per radha's 11/24 comments but I'd really like to know what the other bug is that will track the 'real' fix.
Status: RESOLVED → VERIFIED
marking verified like I said
No longer blocks: 18471
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.