Closed
Bug 18038
Opened 25 years ago
Closed 25 years ago
[dogfood][webshell] Back/Forward buttons updated too early, partially loaded pages removed from SH
Categories
(SeaMonkey :: General, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
M12
People
(Reporter: radha, Assigned: radha)
References
Details
(Whiteboard: [PDT-])
Back/forward buttons are updated before a page finishes loading, which sometimes
misleads users about whether he can actually go back/forward. Update it after a
page finishes loading.
Assignee | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
QA Contact: leger → claudius
Target Milestone: M11
Comment 1•25 years ago
|
||
Isn't this useful when you want to back through a number of pages without
waiting for them all to (re)load? If the buttons aren't updated until the page
has finished loading then what will the back button do if someone presses it
part way through loading a page?
Assignee | ||
Updated•25 years ago
|
Target Milestone: M11 → M13
Assignee | ||
Comment 2•25 years ago
|
||
This wil be addressed the *right* way after the redesigned webshell and session
history lands.
Updated•25 years ago
|
Target Milestone: M13 → M11
Comment 3•25 years ago
|
||
It's updating faster than one might think.
Try going to a domain that doesn't exist. http://www.blahblah.ru/
Netscape 4.08 won't show a back button because you haven't left the page yet.
Instead a popup appears that says something like No DNS entry...
Using Mozilla (Build 1999110708), try clicking "File, Open Web Location" and
type "www.blahblah.ru". Notice the url updated on the browser already and the
buttons say you can go back. But you haven't left whatever page you were on
first (I was on www.yahoo.com before, so it's still there.). So... The problem
seems to be not that the button is updated before the page finishes loading, but
it's updating before the page even begins loading...
Updated•25 years ago
|
Summary: Back/Forward buttons updated too early → [webshell] Back/Forward buttons updated too early
Updated•25 years ago
|
Target Milestone: M11 → M12
Comment 4•25 years ago
|
||
m12.
Assignee | ||
Comment 7•25 years ago
|
||
This bug will address the problem on what gets into SH and what will not. ie.,
partially loaded pages will stay in SH, while unresolved pages won't. The new
BrowserInstance along with new WebShell provides better ways of dealing with
this.
Assignee | ||
Updated•25 years ago
|
Summary: [webshell] Back/Forward buttons updated too early → [dogfood][webshell] Back/Forward buttons updated too early
Assignee | ||
Updated•25 years ago
|
Summary: [dogfood][webshell] Back/Forward buttons updated too early → [dogfood][webshell] Back/Forward buttons updated too early, partially loaded pages removed from SH
Comment 10•25 years ago
|
||
Comment 11•25 years ago
|
||
Radha thinks she has a hack to fix this by M12. The real fix of implementing
nsIStreanListener will come in M13. Leaving this open in M12 for the hack for
now.
Assignee | ||
Updated•25 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 12•25 years ago
|
||
I have commented out the piece of code in Session History that used to remove
partially loaded pages and unresolved pages from SH. So, now partially loaded
pages will stay in SH. So will unresolved pages. To fix this the right way,
nsIBrowserInstance has to implement nsIStreamObserver and hook to
OnDataAvailable(). This will be done after the new webshell is functional and
Browser Instance has gone thro' its round of changes. I'm going to open a new
bug for that and close this one out.
Comment 13•25 years ago
|
||
If you do open another bug please note it here. thanx.
Comment 14•25 years ago
|
||
I can verifiy that this is fixed per radha's 11/24 comments but I'd really like to know what the other bug is
that will track the 'real' fix.
Updated•25 years ago
|
Status: RESOLVED → VERIFIED
Comment 15•25 years ago
|
||
marking verified like I said
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•