Closed
Bug 18063
Opened 25 years ago
Closed 25 years ago
nsXIFDTD.cpp needs some reference counting work - it leaks nsXMLTokenizer objects
Categories
(Core :: DOM: HTML Parser, defect, P3)
Core
DOM: HTML Parser
Tracking
()
VERIFIED
FIXED
People
(Reporter: beard, Assigned: rickg)
References
()
Details
Here's a patch that spot-fixes the nsXMLTokenizer leak, but nsXIFDTD::~nsXIFDTD()
doesn't clear up many other possible references. The URL above points to a line
that instantiates a nsXMLTokenizer object, but it doesn't add the initial
reference.
Index: mozilla/htmlparser/src/nsXIFDTD.cpp
===================================================================
RCS file: /cvsroot/mozilla/htmlparser/src/nsXIFDTD.cpp,v
retrieving revision 1.52
diff -r1.52 nsXIFDTD.cpp
344a345
> NS_IF_RELEASE(mTokenizer);
1537c1538
< if(!mTokenizer)
---
> if(!mTokenizer) {
1538a1540,1541
> NS_IF_ADDREF(mTokenizer);
> }
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
|
Reporter | |
Comment 3•25 years ago
|
||
This hasn't been checked in yet, has it?
Verified on:
build: 2001-03-29-09-Mtrunk
Platform: Win NT
Marked verified as per the above developer (rickg) comments.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•