Closed Bug 18155 Opened 25 years ago Closed 24 years ago

Tinderbox is not valid HTML. Fix tinderbox output to set an example.

Categories

(Webtools Graveyard :: Tinderbox, defect, P5)

x86
Windows 98
defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: kberk.spamaway, Assigned: mcafee)

References

()

Details

The current validation results of tinderbox pages is as follows. Please fix tinderbox to use standards based valid HTML. Lets set an example. W3C HTML Validation Service Results Document Checked URI: http://cvs-mirror.mozilla.org/webtools/tinderbox/showbuilds.cgi?tree=SeaMonkey&h ours=6 Server: Apache/1.3.4 (Unix) Character encoding: unknown Document type: HTML 4.0 Transitional. Below are the results of attempting to parse this document with an SGML parser. Line 1, column 1: <HTML> ^ Error: Missing DOCTYPE declaration at start of document (explanation...) Line 2, column 5: <HTML><HEAD><TITLE>tinderbox: SeaMonkey</TITLE></HEAD><BODY BGCOLOR= ... ^ Error: document type does not allow element "HTML" here Line 10, column 29: <FONT SIZE="+3"><B><NOBR>tinderbox</NOBR></B></FONT> ^ Error: element "NOBR" undefined (explanation...) Line 18, column 7: <script> ^ Error: required attribute "TYPE" not specified Line 49, column 42: + notes[noteid] + "</tr></table>"); ^ Error: end tag for element "TR" which is not open (explanation...) Line 49, column 50: + notes[noteid] + "</tr></table>"); ^ Error: end tag for element "TABLE" which is not open (explanation...) Line 83, column 31: + builds[buildindex] + "</B><BR>" ^ Error: end tag for element "B" which is not open (explanation...) Line 84, column 47: + "<A HREF=" + logurl + ">View Brief Log</A><BR>" ^ Error: end tag for element "A" which is not open (explanation...) Line 85, column 60: + "<A HREF=" + logurl + "&fulltext=1"+">View Full Log</A><BR>" ^ Error: end tag for element "A" which is not open (explanation...) Line 86, column 50: + "<A HREF=" + commenturl + ">Add a Comment</A><BR>" ^ Error: end tag for element "A" which is not open (explanation...) Line 87, column 8: + "</TD></TR></TABLE>"); ^ Error: end tag for element "TD" which is not open (explanation...) Line 87, column 13: + "</TD></TR></TABLE>"); ^ Error: end tag for element "TR" which is not open (explanation...) Line 87, column 21: + "</TD></TR></TABLE>"); ^ Error: end tag for element "TABLE" which is not open (explanation...) Line 108, column 12: <layer name="popup" onMouseOut="this.visibility='hide';" ^ Error: there is no attribute "NAME" (explanation...) Line 108, column 31: <layer name="popup" onMouseOut="this.visibility='hide';" ^ Error: there is no attribute "ONMOUSEOUT" (explanation...) Line 109, column 12: left=0 top=0 bgcolor="#ffffff" visibility="hide"> ^ Error: there is no attribute "LEFT" (explanation...) Line 109, column 18: left=0 top=0 bgcolor="#ffffff" visibility="hide"> ^ Error: there is no attribute "TOP" (explanation...) Line 109, column 28: left=0 top=0 bgcolor="#ffffff" visibility="hide"> ^ Error: there is no attribute "BGCOLOR" (explanation...) Line 109, column 49: left=0 top=0 bgcolor="#ffffff" visibility="hide"> ^ Error: there is no attribute "VISIBILITY" (explanation...) Line 109, column 55: left=0 top=0 bgcolor="#ffffff" visibility="hide"> ^ Error: element "LAYER" undefined (explanation...) Line 113, column 55: left=0 top=0 bgcolor="#ffffff" visibility="hide"> ^ Error: element "LAYER" undefined (explanation...) Line 115, column 20: <table cellspacing=0;cellpadding=0;border=0; ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 116, column 10: <trbgcolor="#F0A000"; ^ Error: an attribute specification must start with a name or name token Line 116, column 10: <trbgcolor="#F0A000"; ^ Error: element "TRBGCOLOR" undefined (explanation...) Line 117, column 23: <td><tablecellpadding=9;cellspacing=3;border=0; ^ Error: an attribute specification must start with a name or name token Line 117, column 23: <td><tablecellpadding=9;cellspacing=3;border=0; ^ Error: element "TABLECELLPADDING" undefined (explanation...) Line 118, column 13: <trbgcolor="#FFFFFF"; ^ Error: an attribute specification must start with a name or name token Line 118, column 13: <trbgcolor="#FFFFFF"; ^ Error: element "TRBGCOLOR" undefined (explanation...) Line 120, column 4: </tr></table></td></tr></table> ^ Error: end tag for element "TR" which is not open (explanation...) Line 120, column 12: </tr></table></td></tr></table> ^ Error: end tag for "TRBGCOLOR" omitted, but its declaration does not permit this (explanation...) Line 118, column 3: <trbgcolor="#FFFFFF"; ^ Error: start tag was here Line 120, column 12: </tr></table></td></tr></table> ^ Error: end tag for "TABLECELLPADDING" omitted, but its declaration does not permit this (explanation...) Line 117, column 6: <td><tablecellpadding=9;cellspacing=3;border=0; ^ Error: start tag was here Line 120, column 12: </tr></table></td></tr></table> ^ Error: end tag for "TRBGCOLOR" omitted, but its declaration does not permit this (explanation...) Line 116, column 0: <trbgcolor="#F0A000"; ^ Error: start tag was here Line 120, column 12: </tr></table></td></tr></table> ^ Error: end tag for "TABLE" which is not finished (explanation...) Line 120, column 17: </tr></table></td></tr></table> ^ Error: end tag for element "TD" which is not open (explanation...) Line 120, column 22: </tr></table></td></tr></table> ^ Error: end tag for element "TR" which is not open (explanation...) Line 120, column 30: </tr></table></td></tr></table> ^ Error: end tag for element "TABLE" which is not open (explanation...) Line 125, column 5: <bold><a href="http://www.mozilla.org/projects/seamonkey/rules/code_re ... ^ Error: element "BOLD" undefined (explanation...) Line 133, column 88: ... /quality/precheckin-tests.html>Precheckin tests</A> ^ Error: end tag for element "A" which is not open (explanation...) Line 134, column 57: ... ns Code Reviewer r=<reveiwers email>, Clear explanation of w ... ^ Error: "EMAIL" is not a member of a group specified for any attribute (explanation...) Line 134, column 57: ... ns Code Reviewer r=<reveiwers email>, Clear explanation of w ... ^ Error: element "REVEIWERS" undefined (explanation...) Line 135, column 4: </ul> ^ Error: end tag for "REVEIWERS" omitted, but its declaration does not permit this (explanation...) Line 134, column 41: ... eckin log contains Code Reviewer r=<reveiwers email>, Clear ... ^ Error: start tag was here Line 185, column 32: width=90 height=90><br> ^ Error: required attribute "ALT" not specified Line 202, column 33: <img src="star.gif"></td><td>= Show Log comments ^ Error: required attribute "ALT" not specified Line 216, column 58: ... a>The tree is currently <font size=+2>CLOSED</font> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 219, column 180: ... did</font><br><font size=-2><a href=showbuilds.cgi?tree=SeaMonkey&hour ... ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 219, column 247: ... ours=6&rebuildguilty=1>Rebuild guilty list</a></td><td rowspan=2 bgcol ... ^ Error: end tag for "FONT" omitted, but its declaration does not permit this (explanation...) Line 219, column 144: ... size=-1>Click name to see what they did</font><br><font size=-2><a hre ... ^ Error: start tag was here Line 223, column 84: ... a href=../bonsai/cvsquery.cgi?module=SeaMonkeyAll&date=explicit&mindat ... ^ Error: general entity "date" not defined and no default entity (explanation...) Line 223, column 98: ... ai/cvsquery.cgi?module=SeaMonkeyAll&date=explicit&mindate=941907654> ^ Error: general entity "mindate" not defined and no default entity (explanation...) Line 224, column 19: 11/06&nbsp;09:00</a></td> ^ Error: end tag for element "A" which is not open (explanation...) Line 253, column 41: ... ign=center><td align=right bgcolor=#e7e7e7><a href=../bonsai ... ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 254, column 19: 11/06&nbsp;08:58</a></td> ^ Error: end tag for element "A" which is not open (explanation...) Line 259, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 265, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 271, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 277, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 283, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 289, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 295, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 301, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 307, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 313, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 319, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 325, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 331, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 337, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 343, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 349, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 356, column 19: 11/06&nbsp;07:58</a></td> ^ Error: end tag for element "A" which is not open (explanation...) Line 451, column 41: ... ign=center><td align=right bgcolor=#e7e7e7><a href=../bonsai ... ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 452, column 19: 11/06&nbsp;06:57</a></td> ^ Error: end tag for element "A" which is not open (explanation...) Line 457, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 463, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 469, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 475, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 481, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 487, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 493, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 499, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 505, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 511, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 517, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 523, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 529, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 535, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 541, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 547, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 553, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 559, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 566, column 19: 11/06&nbsp;05:52</a></td> ^ Error: end tag for element "A" which is not open (explanation...) Line 661, column 41: ... ign=center><td align=right bgcolor=#e7e7e7><a href=../bonsai ... ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 662, column 19: 11/06&nbsp;04:56</a></td> ^ Error: end tag for element "A" which is not open (explanation...) Line 667, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 673, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 679, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 685, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 691, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 697, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 703, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 709, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 715, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 721, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 727, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 733, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 739, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 745, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 751, column 41: <tr align=center><td align=right bgcolor=#e7e7e7> ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 758, column 19: 11/06&nbsp;03:58</a></td> ^ Error: end tag for element "A" which is not open (explanation...) Line 848, column 22: <a href=showbuilds.cgi?tree=SeaMonkey&hours=6&nocrap=1&maxdate=9418861 ... ^ Error: an attribute value must be a literal unless it contains only name characters (explanation...) Line 848, column 173: ... e=SeaMonkey'>Administrate Tinderbox Trees</a><br> ^ Error: "HTML" not finished but document ended Sorry, this document does not validate as HTML 4.0 Transitional. If you use CSS in your document, you should also check it for validity using W3C's CSS Validation Service. Gerald Oskoboiny $Date: 1999/10/27 20:25:33 $
Status: NEW → ASSIGNED
Priority: P3 → P5
Target Milestone: M20
Not real high on my list of priorities right now.
Be nice if it were strict and perhaps even XHTML 1.0:) Lots of scripts to modify however to fix this. I started looking at this several times and understand why nobody is jumping at it:)
I could probably track down many of the problems here, but I'm not sure how I would test the changes to the scripts... What happens when a tinderbox script is modified in CVS?
Exactly the problem. Setting up a test environment for this will be a daunting task. I installed IIS yesterday, so I would have a local web server to use. I have pearl, but I don't have a CVS repository. That is an awfull lot to set up to test this.
If a brave is going to change the tinderbox page generator here are a couple of suggestions. Since all the table needs monospaced text why not having <TT></TT> only once? To make the page source more human readable and debuggable perhaps is useful to put a newline after the followings:</td></a> and two newline after:</tr>
Depends on: 48679
 
Status: ASSIGNED → NEW
QA Contact: matty
slamm no longer owns tinderbox and is no longer at netscape. Reassigning to mcafee till a more permenant owner is found so these bugs won't be ownerless.
Assignee: slamm → mcafee
Unsetting target milestone so we can delete the old (inappropriate) Mozilla target milestones from Webtools.
Target Milestone: M20 → ---
let's fix this in tbox 2.0 codebase.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → WONTFIX
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.