Closed
Bug 18175
Opened 25 years ago
Closed 18 years ago
event target debugging must be added to Mac viewer menu
Categories
(Core :: Layout, enhancement, P4)
Core
Layout
Tracking
()
RESOLVED
WONTFIX
Future
People
(Reporter: dbaron, Assigned: dbaron)
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
Details | Diff | Splinter Review |
To make it easier to fix bugs such as bug 1413, bug 12231, bug 12232, and bug
16548, and find other similar bugs (I already found one on my homepage that I
should report...), I decided to add a new debugging feature.
I'll attach a patch that does everything I want *except* add the necessary
toggle menu-item to viewer. I don't really want to figure out how to do that,
since it looks like it needs to be done for all platforms, and someone else
probably has the experience to do it in a few minutes.
What this patch does is allow a menuitem in viewer (once hooked to one) to cause
the border of the current frame that receives events to be colored (kinda like
Visual Debugging, but changing dynamically).
Right now, it's hooked to the Visual Debugging menu item (that's the change in
the first file in the patch I'll attach) so that once you toggle visual
debugging, it's always on. That worked for testing it, but it's not a great
idea forever.
I think it should be a separate menuitem from Visual Debugging, probably called
something like "Visual Event Target Debugging".
This patch will make it easy to, say, run through CSS test suites and make sure
all the events go to the right places for all advanced CSS features just by
mousing over them.
Assignee | ||
Comment 1•25 years ago
|
||
Assignee | ||
Updated•25 years ago
|
Whiteboard: patch attached
Don't you have a Mozilla account so you can check this into the tree yourself?
Assignee | ||
Comment 3•25 years ago
|
||
No. I haven't actually contributed all that much code. So it would be good if
one of you could check it in...
I am hoping to do a little more coding though... and I *might* be interested in
trying to fix some of the bugs that this turns up. If I have time, and can...
If you want an account, just ask leaf for one. I will vouch for you, of course.
Assignee | ||
Comment 5•25 years ago
|
||
I'm really not sure if I'd want one at this point...
Assignee | ||
Comment 6•25 years ago
|
||
I made an attempt to add it to the viewer menu for all platforms (including
second tier platforms) - but of course I can't test on all platforms, so this
shouldn't be checked in without testing. (I tested it on Linux/GTK only.)
The patch is against a week-old tree, so I'll attach it sometime after I update
my tree, unless you'd like to see it sooner...
Assignee | ||
Comment 7•25 years ago
|
||
Assignee | ||
Comment 8•25 years ago
|
||
I tried to add this to the viewer menu by looking at other people's diffs.
However, Mac menus don't seem to have been updated for a long time, so I didn't
try and touch them. (However, some of the non-first-tier platforms looked
really easy, so they're in the patch. Is that bad?)
This is tested on GTK only.
Assignee | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 10•25 years ago
|
||
Marking Assigned. I'm waiting to hear from joki before I check any of this
in...
Updated•25 years ago
|
Keywords: patch
Summary: [PATCH]event target debugging → event target debugging
Assignee | ||
Comment 11•25 years ago
|
||
The core is checked in. I still have to deal with adding it to the viewer
menus...
Assignee | ||
Comment 12•25 years ago
|
||
This is currently on the viewer menus only on Linux. I need to:
* fix up the way I added it to the Linux menus
* get someone to help adding it to the menus on other platforms
Assignee | ||
Comment 13•25 years ago
|
||
It's now (thanks to rods's help) on the viewer menu on Windows.
Keywords: patch
Whiteboard: patch attached
Assignee | ||
Updated•25 years ago
|
Target Milestone: M15 → M16
Assignee | ||
Updated•25 years ago
|
Summary: event target debugging → event target debugging must be added to Mac viewer menu
Target Milestone: M16 → M18
Assignee | ||
Comment 14•24 years ago
|
||
cc:ing saari since he deals with both events and Macs. If you're ever messing
with viewer, consider doing this. I forgot to do it while I was in MV...
OS: Linux → All
Hardware: PC → All
Assignee | ||
Updated•24 years ago
|
Target Milestone: M18 → ---
Assignee | ||
Comment 15•24 years ago
|
||
Assignee | ||
Updated•24 years ago
|
Whiteboard: [xptest]
Assignee | ||
Comment 16•24 years ago
|
||
Well, that guess was wrong. Apparently I need to change viewer.ppob.
Assignee | ||
Updated•24 years ago
|
Whiteboard: [xptest]
Assignee | ||
Updated•24 years ago
|
Target Milestone: --- → mozilla1.0.1
Assignee | ||
Updated•23 years ago
|
Target Milestone: mozilla1.0.1 → Future
Assignee | ||
Updated•23 years ago
|
Priority: P3 → P4
Updated•23 years ago
|
Attachment #2697 -
Attachment is obsolete: true
Updated•23 years ago
|
Attachment #2847 -
Attachment is obsolete: true
Updated•23 years ago
|
Attachment #18719 -
Flags: needs-work+
Assignee | ||
Comment 17•18 years ago
|
||
Viewer no longer exists.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → INVALID
Assignee | ||
Updated•18 years ago
|
Resolution: INVALID → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•