Closed Bug 1822 Opened 26 years ago Closed 26 years ago

Memory clobber on 64-bit host.

Categories

(MozillaClassic Graveyard :: XFE, defect, P2)

DEC
Linux
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: rth, Assigned: ramiro)

Details

nsToolbarManager::nsToolbarManager() allocates an array of 32-bit quantities and casts that to an array of pointers. Index: nsToolbarManager.cpp =================================================================== RCS file: /cvsroot/mozilla/widget/src/xpwidgets/nsToolbarManager.cpp,v retrieving revision 1.4 diff -c -p -d -u -r1.4 nsToolbarManager.cpp --- nsToolbarManager.cpp 1998/11/05 19:52:48 1.4 +++ nsToolbarManager.cpp 1998/12/09 06:18:07 @@ -63,9 +63,9 @@ nsToolbarManager::nsToolbarManager() : C mNumTabsSave = 0; // XXX Needs to be changed to a Vector class - mToolbars = (nsIToolbar **)new PRInt32[kMaxNumToolbars]; - mTabs = (TabInfo **)new PRInt32[kMaxNumToolbars]; - mTabsSave = (TabInfo **)new PRInt32[kMaxNumToolbars]; + mToolbars = new nsIToolbar* [kMaxNumToolbars]; + mTabs = new TabInfo* [kMaxNumToolbars]; + mTabsSave = new TabInfo* [kMaxNumToolbars]; PRInt32 i; for (i=0;i<kMaxNumToolbars;i++) {
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
I checked in the fix. thanks. marking fixed.
VERIFIED, MozillaClassic is dead.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.