Closed
Bug 18673
Opened 25 years ago
Closed 25 years ago
[PATCH} SUPERWIN fix for picky c++ compilers
Categories
(Core :: XUL, defect, P3)
Tracking
()
VERIFIED
FIXED
People
(Reporter: tor, Assigned: blizzard)
Details
A little shuffling of include files is needed to avoid glib's erroneous
definition of NULL:
Index: nsGtkEventHandler.cpp
===================================================================
RCS file: /cvsroot/mozilla/widget/src/gtk/nsGtkEventHandler.cpp,v
retrieving revision 1.112.2.5
diff -u -r1.112.2.5 nsGtkEventHandler.cpp
--- nsGtkEventHandler.cpp 1999/11/09 23:05:40 1.112.2.5
+++ nsGtkEventHandler.cpp 1999/11/12 18:02:29
@@ -20,9 +20,6 @@
* Contributor(s):
*/
-#include "gtk/gtk.h"
-#include "nsGtkEventHandler.h"
-
#include "nsWidget.h"
#include "nsWindow.h"
@@ -42,6 +39,9 @@
#include "stdio.h"
#include "ctype.h"
+
+#include "gtk/gtk.h"
+#include "nsGtkEventHandler.h"
#include <gdk/gdkkeysyms.h>
#include <X11/Xlib.h>
Index: nsWindow.cpp
===================================================================
RCS file: /cvsroot/mozilla/widget/src/gtk/nsWindow.cpp,v
retrieving revision 1.187.2.26
diff -u -r1.187.2.26 nsWindow.cpp
--- nsWindow.cpp 1999/11/10 21:29:44 1.187.2.26
+++ nsWindow.cpp 1999/11/12 18:02:30
@@ -20,6 +20,8 @@
* Contributor(s):
*/
+#include "stdio.h"
+
#include <gtk/gtk.h>
#include <gdk/gdkx.h>
@@ -44,8 +46,6 @@
#include "nsIRollupListener.h"
#include "nsGtkUtils.h" // for nsGtkUtils::gdk_window_flash()
-
-#include "stdio.h"
// this is the nsWindow with the focus
nsWindow *nsWindow::focusWindow = NULL;
Assignee | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•25 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 1•25 years ago
|
||
Looks good to me. Checked in. Thanks!
Updated•25 years ago
|
Status: RESOLVED → VERIFIED
Comment 2•25 years ago
|
||
code level fix, marking VERIFIED
Assignee | ||
Comment 3•25 years ago
|
||
Please ignore the spam. Changing address.
Assignee: blizzard → blizzard
Status: VERIFIED → NEW
Assignee | ||
Comment 4•25 years ago
|
||
bustage from my reassign
Status: NEW → RESOLVED
Closed: 25 years ago → 25 years ago
You need to log in
before you can comment on or make changes to this bug.
Description
•