Closed
Bug 19127
Opened 25 years ago
Closed 25 years ago
[dogfood]Windows Seamonkey commercial build system not detecting and stopping on build errors.
Categories
(SeaMonkey :: Build Config, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
M12
People
(Reporter: ssu0262, Assigned: leaf)
Details
(Whiteboard: [PDT+] 12/6 Need leaf to Verify,)
The daily windows seamonkey commercial build system does not detect when the
build fails (tinderbox seems to be able to detect it). It should detect build
errors and not deliver to sweetlou areas in such a case.
This is causing deliverables of mozilla seamonkey bits instead of the commercial
seamonkey bits. This in turn causes people to test the wrong builds and also
file bugs against xpinstall/wizard installer when it's really not the case.
Here's an example of what happens:
1) build system builds mozilla seamonkey bits
2) build system builds commercial seamonkey bits using mozilla seeamonkey bits,
but fails.
3) build system ends up delivering mozilla seamonkey bits and installer bits to
sweetlou.
Since the mozilla seamonkey bits do not build the .xpi files during the install
build process, the mozilla seamonkey installer is half built, meaning that it
can't install anything.
This state of the mozilla seamonkey installer is then passed over to the
commercial seamonkey build system. Then, when the commercial seamonkey build
system fails before building the windows wizard installer, it delivers this
not-quite-working installer to sweetlou for testing.
However, if the commercial seamonkey build system succeeds, the installer works
fine.
There should be a mechanism to detect that a simple nmake.exe had failed (or
however tinderbox does it). A more elaborate error detection system can be
later incorporated, if need be.
Assignee | ||
Updated•25 years ago
|
Assignee: cyeh → leaf
Assignee | ||
Comment 1•25 years ago
|
||
Right now this stuff is in a batch file. If someone can help me figure out how
to check return status in batch files, i can fix the script. Otherwise, i need
to rewrite in perl to check.
Updated•25 years ago
|
Summary: Windows Seamonkey commercial build system not detecting and stopping on build errors. → [dogfood]Windows Seamonkey commercial build system not detecting and stopping on build errors.
Comment 2•25 years ago
|
||
added "dogfood" to the summary for consideration by PDT team. This is bad.
Comment 3•25 years ago
|
||
Leaf, you can check status in a batch file using "errorlevel". For example, "if
error level 1" means that the "if" clause is executed if the previous app
returned a status code greater than 1.
Updated•25 years ago
|
Whiteboard: [PDT+] → [PDT+] 12/6
Assignee | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•25 years ago
|
||
Testing `if errorlevel 1 goto dienetscape' in production scripts; if the build
succeeds, i'll sabotage it and see if i can get failure detection (tested on
depth=1 nmake, want to test that the errorlevel is propogated up to the top
nmake process).
Assignee | ||
Updated•25 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•25 years ago
|
||
this seems to be working. When we have build bustage on a real day, someone can
mark this verified.
Comment 7•25 years ago
|
||
On "real days" we don't get bustage ;-)
thanks leaf
Assignee | ||
Comment 9•25 years ago
|
||
I'm the person that fixed! Should i really be the one to verify?
Comment 10•25 years ago
|
||
Marking Verified per chofmann...he gave me the ok! :-)
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•