Closed
Bug 19373
Opened 25 years ago
Closed 25 years ago
[DOGFOOD]option elements don't update their label correctly
Categories
(Core :: Layout, defect, P3)
Tracking
()
VERIFIED
FIXED
M12
People
(Reporter: rods, Assigned: rods)
References
Details
(Whiteboard: [PDT+] 3-Dec-1999)
Attachments
(2 files)
(deleted),
text/html
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•25 years ago
|
||
This actually show two problems:
1) The option element gets its "label" attr set but is never asked to reflow to
display the new value. The following lines get executed in
nsGenericHTMLElement.cpp:
if (aNotify && (nsnull != mDocument)) {
mDocument->AttributeChanged(mContent, aNameSpaceID, aAttribute,
NS_STYLE_HINT_UNKNOWN);
}
I think the unknown hint makes it not reflow.
Problem #2:
The combobox frame needs to be notified that the selected option's label or
content was changed so it can update itself properly and reflow.
It could be an optimized notification (only happens when the selected object is
changed) or a more general notification.
Assignee | ||
Comment 2•25 years ago
|
||
after the label is set select the second item. The "hello" shows up in the combo
display area but the option frame doesn't display the new value.
Updated•25 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [PDT+] → [PDT+] 26-Nov-1999
Comment 4•25 years ago
|
||
I've tried returning a style hint of reflow for changes of the label attribute
on an option. Unfortunately, this isn't quite enough. It updates the label
displayed in the text field of a combobox when the option is selected, but does
not update the label displayed in the listbox. Returning a style hint of
'framechange' has the exact same effect. It seems the only hint guaranteed to
update all of the display as needed is 'reconstruct all' which is a bit extreme
for this situation. I'll continue working on this until I have a reasonable
solution.
Comment 5•25 years ago
|
||
This seems like a relatively minor UI issue - is this bug blocking development?
Updated•25 years ago
|
Whiteboard: [PDT+] 26-Nov-1999 → [PDT+] 3-Dec-1999
Assignee | ||
Comment 6•25 years ago
|
||
The problem is when when RDF loads all the items and the options get different
labels the select actually displays the wrong value until you click on it.
So it isn't blocking development, but it is a critical (blocking) issue for the
UI)
Comment 9•25 years ago
|
||
I have a patch for problem 1) but not problem 2). Attaching the patch.
Comment 10•25 years ago
|
||
Assignee | ||
Updated•25 years ago
|
Assignee: pollmann → rods
Status: ASSIGNED → NEW
Assignee | ||
Comment 11•25 years ago
|
||
Taking the bug
Assignee | ||
Updated•25 years ago
|
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 12•25 years ago
|
||
passes back reflow hint and notifies the combox it should update its
display - fixed
Updated•25 years ago
|
Status: RESOLVED → VERIFIED
Comment 13•25 years ago
|
||
Fixed in the Dec 9th build (1999120908)
SPAM. HTML Element component deprecated, changing component to Layout. See bug
88132 for details.
Component: HTML Element → Layout
You need to log in
before you can comment on or make changes to this bug.
Description
•