Make fails for the following directories: layout/html/tests layout/base/tests layout/tools

Why are layout bugs going to toshok by default? Reassigning to rickg.

This may be nothing -- or just old. Please look.

I have no way to build on Linux from home, so maybe Kevin can take a look at this?

Looks like we are building and bundling the following in the daily linux builds. DumpColors FilesTest RegFactory TestAtoms TestCRT TestColorNames TestFactory TestRec Are there other test programs that should be getting built? leaf/donm, can you have a look at what is going on in the daily verifcation builds in these directories?

Looks like we are building and bundling the following in the daily linux builds. DumpColors FilesTest RegFactory TestAtoms TestCRT TestColorNames TestFactory TestRec Are there other test programs that should be getting built? leaf/donm, can you have a look at what is going on in the daily verifcation builds in these directories?

Inserting Milestone info.

Setting all current Open/Normal to M4.

html & base tests are working on Linux, moving this bug to focus on the tools stuff.

Kipp, is there anything to build in layout/tools? It's not clear there's anything to do here for Unix, but I see Makefile.in sitting there.

Theres some reference files and genhash.pl script. I think Chris Seawood added this makfile for completeness, but its not really needed.

I fixed the stuff to build on linux (yay). However, you must install the gperf rpm and build it before you can expect the build in that directory to work (sigh) and gperf wasn't part of my standard linux install (its easy to get and build, however).

I fixed the stuff to build on linux (yay). However, you must install the gperf rpm and build it before you can expect the build in that directory to work (sigh) and gperf wasn't part of my standard linux install (its easy to get and build, however).

presuming akkana agrees with the fix, will mark as verified.

I have gperf-2.7-2. When I type make in objdir/layout/tools, it creates a bunch of .cpp files, but doesn't actually compile anything. Is that what it's supposed to do? If I build in objdir/layout/html/tests, I get a link error: /usr/bin/ld: warning: libraptorhtmlpars.so, needed by ../../../dist/./bin/libraptorhtml.so, not found (try using --rpath) /usr/bin/ld: warning: libraptorgfx.so, needed by ../../../dist/./bin/libraptorhtml.so, not found (try using --rpath) /usr/bin/ld: warning: libjsdom.so, needed by ../../../dist/./bin/libraptorhtml.so, not found (try using --rpath) ../../../dist/./bin/libraptorhtml.so: undefined reference to `NS_NewScriptDocument' ../../../dist/./bin/libraptorhtml.so: undefined reference to `NS_TagToEnum(char const *)' ../../../dist/./bin/libraptorhtml.so: undefined reference to `nsRect::Deflate(int, int)' ../../../dist/./bin/libraptorhtml.so: undefined reference to `NS_NewScriptStyleSheetCollection' ../../../dist/./bin/libraptorhtml.so: undefined reference to `nsRect::Deflate(nsMargin const &)' ../../../dist/./bin/libraptorhtml.so: undefined reference to `NS_ColorNameToRGB' ../../../dist/./bin/libraptorhtml.so: undefined reference to `NS_NewScriptHTMLCollection' ../../../dist/./bin/libraptorhtml.so: undefined reference to `operator<<(_IO_FILE *, nsRect const &)' ../../../dist/./bin/libraptorhtml.so: undefined reference to `NS_NewScriptEventListener' ../../../dist/./bin/libraptorhtml.so: undefined reference to `nsRect::IntersectRect(nsRect const &, nsRect const &)' ../../../dist/./bin/libraptorhtml.so: undefined reference to `NS_Get3DColors' ../../../dist/./bin/libraptorhtml.so: undefined reference to `NS_NewImageGroup' ../../../dist/./bin/libraptorhtml.so: undefined reference to `NS_NewWellFormed_DTD(nsIDTD **)' ../../../dist/./bin/libraptorhtml.so: undefined reference to `NS_NewScriptCSSStyleRuleCollection' ../../../dist/./bin/libraptorhtml.so: undefined reference to `NS_EnumToTag(nsHTMLTag)' ../../../dist/./bin/libraptorhtml.so: undefined reference to `NS_NewNavHTMLDTD(nsIDTD **)' ../../../dist/./bin/libraptorhtml.so: undefined reference to `nsFont::nsFont(char const *, unsigned char, unsigned char, unsigned short, unsigned char, int)' ../../../dist/./bin/libraptorhtml.so: undefined reference to `nsRect::Inflate(int, int)' ../../../dist/./bin/libraptorhtml.so: undefined reference to `NS_GetSpecial3DColors' ../../../dist/./bin/libraptorhtml.so: undefined reference to `NS_NewScriptCSSStyleRule' ../../../dist/./bin/libraptorhtml.so: undefined reference to `nsFont::nsFont(nsFont const &)' ../../../dist/./bin/libraptorhtml.so: undefined reference to `nsRect::Contains(int, int) const' ../../../dist/./bin/libraptorhtml.so: undefined reference to `NS_EntityToUnicode(char const *)' ../../../dist/./bin/libraptorhtml.so: undefined reference to `NS_HexToRGB' ../../../dist/./bin/libraptorhtml.so: undefined reference to `NS_NewScriptCSS2Properties' ../../../dist/./bin/libraptorhtml.so: undefined reference to `nsFont::operator=(nsFont const &)' ../../../dist/./bin/libraptorhtml.so: undefined reference to `nsFont::~nsFont(void)' ../../../dist/./bin/libraptorhtml.so: undefined reference to `NS_LooseHexToRGB' ../../../dist/./bin/libraptorhtml.so: undefined reference to `NS_NewScriptHTMLDocument' ../../../dist/./bin/libraptorhtml.so: undefined reference to `NS_NewScriptCSSStyleSheet' and similarly in layout/base/tests. If I try to build from the top with --enable-tests, then it tries to build these .cpp files, but fails: nsColorNames.cpp:2: syntax error before `::' What is the approved way to build tests so that these errors don't happen, and why can't I just cd into the directory and type "make" to make them?

Building in layout/tools only generates source files and then copies them into place where later builds can use them. The only time the build is done is when generated files need updating (we don't normally generate generated files during the build - especially this directory). So, in summary, yes its working correctly. If you are having problems building in layout/base/tests and layout/html/base/tests during a normal build, please file a new bug.

marking verified