Closed
Bug 20090
Opened 25 years ago
Closed 25 years ago
nsWebShell::Embed sometimes returns garbage
Categories
(SeaMonkey :: General, defect, P3)
SeaMonkey
General
Tracking
(Not tracked)
VERIFIED
FIXED
M15
People
(Reporter: hjtoi-bugzilla, Assigned: travis)
References
()
Details
(Keywords: verifyme)
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
In the beginning of the Embed method we have
nsresult rv;
but if mWindow == nsnull the function returns the unitialized rv.
A related note. If mWindow == nsnull, the function nulls out mContentViewer. But
if it was not null, this results in bad refcounts & memory leaks.
Also, why does it need to null out mContentViewer? For example, (well, this may
be misuse but this is what I have done right now and it would require a lot of
changes to do it otherwise), I have a command-line application (no windows) that
loads documents with the webshell. Strange as this may sound, it works except
for this Embed part, because if this Embed nulls out mContentViewer I can never
get the document object out once it has been loaded.
Reporter | ||
Updated•25 years ago
|
Assignee: leger → travis
Reporter | ||
Comment 1•25 years ago
|
||
Oops, wrong Assigned To. I'll make a patch as well...
Reporter | ||
Comment 2•25 years ago
|
||
This function will be going away completely very soon now with the webShell
redesign.
The Embed method is gone for nearly all purposes. It's implementation is
provided by another internal interface. Marking this fixed since all the code
is new.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•