Closed Bug 20229 Opened 25 years ago Closed 25 years ago

[MLK] Leaking nsDeque objects

Categories

(Core :: DOM: HTML Parser, defect, P3)

Product:
Core
Component:
DOM: HTML Parser
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: beard, Assigned: rickg)

References

(
URL
)

Details

Attachments

(1 file)

annotated stack crawl
(deleted), text/html
Details
nsCParserNode::~nsCParserNode() can (and does apparently) leak nsDeque objects, since it only conditionally deletes mAttributes. I'm enclosing a report for such a leak.
Attached file annotated stack crawl (deleted) —
Status: NEW → ASSIGNED
The problem is in XIFDTD; nodes will leak children if the nodes themselves are not handled properly.
But I didn't see nodes leaking, just nsDeques leaking by themselves. Do you not agree that there's a possibility that the deque isn't deleted because of the way you've written nsCParserNode::~nsCParserNode()?
No -- the attributes deque is being deleted when the node gets destroyed.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Patrick is the man! Bug was caused by erroneous conditional, which caused mAttributes deque to leak if it existed but was empty.
updated qa contact.
QA Contact: janc → bsharma
Marking verified as per the developer comments.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: