Closed Bug 20339 Opened 25 years ago Closed 24 years ago

'twisty' image doesn't change to busy animation when loading subdirectory

Categories

(Core :: XUL, defect, P3)

Other
Other
defect

Tracking

()

RESOLVED FIXED
Future

People

(Reporter: ckritzer, Assigned: waterson)

References

()

Details

(Keywords: helpwanted)

Attachments

(2 files)

Overview Description: When in a tree view (or ftp directory view), selecting a
twisty (right-pointing triangle image) is not causing a busy animation to load
in its place while the browser loads the subdirectory into the current window.

Steps to Reproduce:
1) Launch Linux6 or WinNT 1999112908 apprunner
2) Load the 'file:///' url into the location field (you will most likely have
the root level directory of your linux system displayed)
3) Click on the twisty of a directory that has a lot of files and/or directories
in it (I chose 'bin')


Actual Results: The right-pointing twisty disappears and there is a blank space
where the busy animation should be.  When the subdirectory is loaded, the
down-pointing twisty appears.  (This also happens on Windows, but it is more
brief and less noticeable.)

Expected Results: The busy animation should appear in place of the
right-pointing twisty while loading the subdirectory

Build Date & Platform Bug Found:
	Linux6 1999112908 apprunner

Additional Builds and Platforms Tested On:
	MacOS86 1999112908 apprunner
	WinNT 1999112908 apprunner

Additional Information:
Assignee: trudelle → waterson
reassigning to waterson per hyatt
Status: NEW → ASSIGNED
Target Milestone: M15
This seems to work now on Linux 2000.01.08.08
I can still reproduce this with the 2000.01.11.10 Linux builds on RH6.
Target Milestone: M15 → M16
nominating for nsbeta2 based on:
 - severity
 - visibility
Keywords: nsbeta2
Updating QA Contact...and jrgm, I need test result with the latest good build 
please.
QA Contact: claudius → jrgm
Whiteboard: [NEED INFO]
Due to the recent purge of 'child > child > child' selectors, at this
time, the twisty icon (for any state) is not displaying for listings
of either file or ftp directories. (mac/win32/linux 20000426nn).

However, last time I recall (before the purge) the animated icon
would display during loading of sub-folders. Setting this dependent
on bug #37322 "Twisties in ftp directory tree have disappeared".
[Also, this isn't 'critical' as in crash/leak/etc.]
Severity: critical → normal
Depends on: 37322
have info (forgot to remove status whiteboard)
Whiteboard: [NEED INFO]
Re-evaluated.  Removing nsbeta2 as this is more cosmetic that functional.

But you can bet it'll be there for nsbeta3 <grin>
Keywords: nsbeta2
-> M20
Target Milestone: M16 → M20
Keywords: helpwanted
Target Milestone: M20 → Future
Hey, we have to have twisties!  I tracked this down a bit... when the 
directoryviewer Asserts(knc_loading), it ends up getting into the XUL template 
builder's OnAssert() method, which then hits this line:

    if (mIsBuilding)
        return NS_OK;

and just returns.  A new limitation?  Chris, any thoughts on how we can work 
around this?
That means that further up the stack somewhere, you're already in the XUL 
template builder. This would re-enter it, and generally cause all hell to break 
loose. See bug 39699, r=rjc ;-)

Maybe put the change to make it a twisty on a time-out?
Damn.

I think that the XUL template builder needs to be re-entrant, otherwise the 
"view model" is imposing restrictions on the "data model".  Oh well... maybe for 
version 6.1 eh?

I'll try tweaking the code that sets the "loading" status.
Chris, care to look over these changes?  They get twisters working again for FTP 
requests.

One thing I've noticed: while these changes work 100% on Mac, on Windows (haven't 
tried Linux) the first FTP page doesn't get twisties... but all FTP pages 
afterwards do. That's with the XUL cache enabled. However, if you disable the XUL 
cache, then the first FTP page will get twisties as well.
r=waterson

FWIW, the XUL template builder is re-entrant. The layout engine is where all 
hell breaks loose...
Fix checked in.

Again, note that the busy animation often doesn't show up on the first FTP page 
loaded, but now at least it does on all FTP pages loaded afterwards... (appears 
to be a XUL cache problem.)
This never got marked as fixed.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: