Closed Bug 20714 Opened 25 years ago Closed 25 years ago

[DOGFOOD] build crashes in profile manager at launch

Categories

(Core Graveyard :: Profile: BackEnd, defect, P1)

x86
Linux
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: cpratt, Assigned: waterson)

References

Details

(Whiteboard: [PDT+] 12/10)

Attachments

(2 files)

Build ID: 1999120308 Platform: Linux To reproduce: - At the command prompt, type ./mozilla Result: The application freezes. According to granrose, it quits on his machine. Expected result: The app launches. Workaround: ./mozilla -installer will allow you to launch the app.
Assignee: leger → selmer
Component: Browser-General → Profile Manager
QA Contact: leger → cpratt
when starting mozilla without a ~/.mozilla directory, I get the following: buell.mcom.com:208% ./mozilla MOZILLA_FIVE_HOME=/u/granrose/communicator/linux/package LD_LIBRARY_PATH=/u/granrose/communicator/linux/package/Cool:/u/granrose/communicator/linux/package:/usr/lib:/usr/openwin/lib XPCS_HOME=/u/granrose/communicator/linux/package/Cool MOZ_PROGRAM=./mozilla-bin MOZ_TOOLKIT= moz_debug=0 moz_debugger= nNCL: registering deferred (0) got a request buell.mcom.com:209% It shows the "create new profile" window for about 3 seconds and then it disappears.
I wiped out my Users50 directory and restarted Mozilla. Mozilla (the browser) always launches just fine. But if I click on the mail button on the bottom left (or select Tasks - Mail), then it crashes. This was on WinNT Build 199120308. This is clearly a regression. My command line shows: "nsXULKeyListenerImpl::Init() attempt to UpgradePrefs. If that fails, open the account wizard." Launching ./mozilla -installer didn't help. In fact, if I click on "New" in the Profiles and Migration box: Mozilla crashes.
OS: Linux → All
jelwell: that sounds like bug 20722.
Summary: 1999120308 build crashes at launch → build crashes in profile manager at launch
OS: All → Linux
now if I remove my .mozilla directory and run ./mozilla with the 1999120311 builds, it doesn't exit, but gives this error: buell.mcom.com:120% ./mozilla MOZILLA_FIVE_HOME=/u/granrose/communicator/linux/package LD_LIBRARY_PATH=/u/granrose/communicator/linux/package/Cool:/u/granrose/communicator/linux/package:/usr/lib:/usr/openwin/lib:/builds/mozilla/dist/bin XPCS_HOME=/u/granrose/communicator/linux/package/Cool MOZ_PROGRAM=./mozilla-bin MOZ_TOOLKIT= moz_debug=0 moz_debugger= nNCL: registering deferred (0) got a request JavaScript Error: TypeError: contentWindow has no properties URL: chrome://profile/content/createProfileWizard.js LineNo: 166 and I get the following when I click any of the buttons in the create new profile window: JavaScript Error: TypeError: contentWindow has no properties URL: chrome://profile/content/createProfileWizard.js LineNo: 174 I have to close the window to get it to stop as cancel doesn't work.
Assignee: selmer → racham
Severity: critical → blocker
Priority: P3 → P1
Summary: build crashes in profile manager at launch → [DOGFOOD] build crashes in profile manager at launch
Target Milestone: M12
This is holding the tree closed, marking so. Assigning to racham.
Assignee: racham → travis
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
dom checkins should fix this.
Status: RESOLVED → VERIFIED
Using the 1999120311 (11:58 am) build on Linux, I no longer crash at startup. Marking verified.
Status: VERIFIED → ASSIGNED
Please use command line option mozilla -CreateProfile "profileName profileDir" to create a profile and to proceed using browser while I investigate the problem. This got to be a new JS problem. Adding Brendan and Seth to the cc list as the JS error coming the code they touched.
That is a Win32-only commandline, no?
this is a linux command line as well. with the 11am builds with both travis' dom fixes, it does not exit, but still gives an error if you have no ~/.mozilla directory and click on "Next" in the create new profile window. clicking cancel will close the window however.
this is what I got on my linux console when I start with no .mozilla and click Next, then Cancel: buell.mcom.com:33% ./mozilla MOZILLA_FIVE_HOME=/u/granrose/communicator/linux/package LD_LIBRARY_PATH=/u/granrose/communicator/linux/package/Cool:/u/granrose/comm unicator/linux/package:/usr/lib:/usr/openwin/lib:/builds/mozilla/dist/bin XPCS_HOME=/u/granrose/communicator/linux/package/Cool MOZ_PROGRAM=./mozilla-bin MOZ_TOOLKIT= moz_debug=0 moz_debugger= nNCL: registering deferred (0) JavaScript Error: TypeError: contentWindow has no properties URL: chrome://profile/content/createProfileWizard.js LineNo: 166 JavaScript Error: TypeError: contentWindow has no properties URL: chrome://profile/content/createProfileWizard.js LineNo: 174 This could be symtomatic of a larger problem with javascript and/or buttons.
Not quite fixed on linux. nuke ~/.mozilla, and get the following: buell.mcom.com:51% ./mozilla MOZILLA_FIVE_HOME=/u/granrose/communicator/linux/package LD_LIBRARY_PATH=/u/granrose/communicator/linux/package/Cool:/u/granrose/communicator/linux/package:/usr/lib:/usr/openwin/lib:/builds/mozilla/dist/bin XPCS_HOME=/u/granrose/communicator/linux/package/Cool MOZ_PROGRAM=./mozilla-bin MOZ_TOOLKIT= moz_debug=0 moz_debugger= nNCL: registering deferred (0) got a request got a request got a request Error: Can't load: file:////u/granrose/communicator/linux/package/chrome/profile/content/default/null.xul (8052e891) JavaScript Error: TypeError: contentWindow.GetFields is not a function URL: chrome://profile/content/createProfileWizard.js LineNo: 174 the first error is from hitting Next, the javascript error is from hitting finish.
Resolution: FIXED → ---
Whiteboard: PDT+
Whiteboard: PDT+ → [PDT+]
I have all of travis' changes, I cannot get through new profile creation still. (Linux)
I'm experiencing this on winnt as well: Opening file null.xul failed Error: Can't load: file:///E|/Projects/mozilla/dist/WIN32_D.OBJ/bin/chrome/profile/content/default/ null.xul (8052e891)
workaround: <sleestack> edburns: mozilla -CreateProfile "profileName profileDir"
has anyone tried this with the updates to mozilla/rdf? I just found out I missed the updates travis did at 11:29 and didn't realize it until I pulled waterson's recent checkin.
nevermind, I just got the latest linux builds, still broken.
I'm looking at this. It looks like there is an IFRAME that gets its src= URL set to chrome://profile/content/null.xul (setting breakpoint in nsWebShell::LoadURL got me that). Can't seem to figure out who's doing it.
Ok, it looks like what is happening is that wrong event handler is firing. Instead of firing "onFinish()", it's firing "onNext()" when you press the "Finish" button. sspitzer: any clue why this might be happening?
I bet what's broken is this: http://lxr.mozilla.org/mozilla/source/profile/resources/content/createProfileWi zard.js#119 The code that does a setAttribute() to change the event handler. Digging...
Assignee: travis → waterson
Status: ASSIGNED → NEW
Okay, I think I know what the problem is. Brendan's change caches the compiled script, and doesn't account for somebody changing the string value later. I'll fix it.
right, in createProfileWizard.js, we change the onclick handler dynamically. line 119: nextButton.setAttribute("onclick","onFinish(opener)"); nice work, waterson.
Status: NEW → RESOLVED
Closed: 25 years ago25 years ago
Resolution: --- → FIXED
fix checked in
*** Bug 20820 has been marked as a duplicate of this bug. ***
Status: RESOLVED → REOPENED
Re-opening. Okay. Still crashes (or simply never never never loads) from the profile manager in: - Linux6 1999120613 mozilla But only if you have less than or more than 1 (one) profile and only after you select the profile from the Profile Manager. If you have only one profile, force mozilla to load the Profile Manager (mozilla.exe -ProfileManager [windows] or mozilla.sh -ProfileManager [linux]) and select the only profile, it will load fine. Also checked (and behaves correctly) on: - MacOS86 1999120608 - WinNT 1999120608
Resolution: FIXED → ---
I can reproduce the crash. Running in debugger just hangs. This is going to be tough to figure out.
Status: REOPENED → ASSIGNED
Whiteboard: [PDT+] → [PDT+] 12/10
Attached patch proposed fix (deleted) — Splinter Review
Turns out that we had two JS Runtimes fighting each other for control of the earth. That, plus a couple of rooting bugs made for some pretty cool sprinking of 0x4 (the JS GC mark bit) throughout random memory.
Cc'ing alecf, cuz he volunteered to clean up (rewrite and make ownable) componentized pref code. Plus, I think he XPConnected the motherless old code in the first place, which exposed objects from the secret "config" runtime to the one true runtime. /be
Sounds similar to dougt's 20964 -- wanna check Waterson's fix Doug?
Attached patch jsatom debugging code (deleted) — Splinter Review
yup, that would have been me who both volunteered and did some damage a while ago in the name of scripting prefs. :) If waterson's fix fixes this bug, I'd rather have a fresh bug for cleanup of prefs.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago25 years ago
Resolution: --- → FIXED
Don't get me wrong: alecf, kudos to you for adding scriptability to prefs, enabling the XUL/JS modern world that wouldn't exist without it -- kudos too for offering to fix up prefs later. The bug I just filed for that later cleanup is bug 21135. /be
*** Bug 20868 has been marked as a duplicate of this bug. ***
Status: RESOLVED → VERIFIED
Haven't seen this happening in some time... Verified using the 1999121308 build, Linux.
Component: Profile Manager → Profile Manager BackEnd
Moving all Profile Manager bugs to new Profile Manager Backend component. Profile Manager component to be deleted.
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: