Closed
Bug 20997
Opened 25 years ago
Closed 25 years ago
Don't discard non-ascii characters, even in us-ascii charset
Categories
(MailNews Core :: Internationalization, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
M13
People
(Reporter: rzach, Assigned: nhottanscp)
Details
Attachments
(2 files)
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review |
If the header of a message claims charset="us-ascii", non-ascii characters are
discarded. Educated guess at the encoding, or just assuming 8859-1 would be
better. Apparently some clients aren't smart enought to set the encoding right.
Assignee | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Target Milestone: M13
Assignee | ||
Comment 1•25 years ago
|
||
This bug is about viewing messages.
We do not plan to do guessing if the message is labeled (we do charset detection
in case of no charset label specified). We plan to enable charset menu so the
user can set a charset explicitly (bug 5938).
Before M12, "ISO-8859-1" was used for "us-ascii" conversion (since no converter
was available for "us-ascii" in early mozilla). I can change it again to use
8859-1 for us-ascii.
Comment 2•25 years ago
|
||
Assuming iso-8859-1 for us-ascii is not a bad idea. It could save the user trouble of having to
override a wrong charset label. Note that us-ascii is sometimes used incorrectly for other charsets
also. But if we were to make an assumption about the super-set of us-ascii, iso-8859-1 is probably
the best choice.
Assignee | ||
Comment 3•25 years ago
|
||
Assignee | ||
Comment 4•25 years ago
|
||
Assignee | ||
Comment 5•25 years ago
|
||
Rich, could you review the diff? This has been done for header but not for body.
Assignee | ||
Comment 6•25 years ago
|
||
The code has been reviewed, waiting for a check in approval.
Comment 7•25 years ago
|
||
Patch looks safe to me.
- rhp
Assignee | ||
Updated•25 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•25 years ago
|
||
The fix checked in.
Updated•25 years ago
|
Status: RESOLVED → VERIFIED
Comment 9•25 years ago
|
||
** Checked with 1/13/00 Win32 M13 build **
The result looks good. With M12 build, QP'ed Latin 1 characters did not
display OK if the charset was us-ascii. Now with the fix in the code, the same
message displays the Latin 1 accented characters OK even under us-ascii
MIME charset. (See nhotta's test case attached to this report.)
Marking it verified fixed.
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•