Closed Bug 21024 Opened 25 years ago Closed 25 years ago

nsEditor::SetAttribute() needs undo transaction

Categories

(Core :: DOM: Editor, defect, P3)

All
Windows NT
defect

Tracking

()

VERIFIED WORKSFORME

People

(Reporter: cmanske, Assigned: cmanske)

References

Details

Attachments

(1 file)

This method creates a transaction and thus should be undoable. An example of its use is when inserting a table row when there is colspan >1. I'll supply a test file shortly.
To test the bug: 1. Open attached test file. 2. Place caret in cell with "10". 3. Execute Table | Insert | Row You should see a new row of cells, and the cell with "6" had its COLSPAN increased by 1. 4. Execute File | Undo The insert cells are removed, but the colspan in cell with "6" is not restored.
Target Milestone: M13
setting to M13
Assignee: buster → cmanske
the test case seems to work already, and on inspection ChangeAttributeTxn (which does all the work for nsEditor::SetAttribute()) looks correct. Reassigning to Charley for more info about what is needed.
Status: NEW → ASSIGNED
This seems to be working, but there are some table display problems I want to investigate before closing this.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Depends on: 22246
Resolution: --- → WORKSFORME
I don't think we (editor team) did anything to fix this, but it does seem to work now. Because of bug 22246, inserting a row or column in a location that changes COLSPAN or ROWSPAN won't redraw the table correctly. Thus validiting this is indirect: 2. Execute the menu command "Debug | Test Table Layout". Note that the 2nd cell in second row has a ROWSPAN = 3. 1. Follow the directions to insert a new row in the attached test file. Either "Row above" or "Row below" can be used. 2. Execute "Test Table Layout" again and now the ROWSPAN is 4. 3. Execute Undo, then Test Table Layout again and the ROWSPAN is changed back to 3.
Status: RESOLVED → VERIFIED
verified in 12/3 build.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: