Closed
Bug 21629
Opened 25 years ago
Closed 24 years ago
some frames are being passed to interfaces that assume refcounting
Categories
(Core :: Layout: Form Controls, defect, P3)
Tracking
()
VERIFIED
FIXED
M15
People
(Reporter: buster, Assigned: rods)
References
Details
(Keywords: memory-footprint, memory-leak, Whiteboard: [nsbeta3+]; requesting engineer feedback-ckritzer;)
nsListControlFrame, nsFileControlFrame, and nsComboBoxControlFrame all suffer
from the same basic problem as nsSliderFrame: they implement listener
interfaces directly but they are not refcounted objects. They should create
intermediate event listener objects that contain a weak reference back to the
frame they represent. They also should not override AddRef() and Release()
See bug 21571 for details.
I completely agree with Steve's analysis of the problem and his proposed
solution
Assignee | ||
Comment 2•25 years ago
|
||
I really only want to do this once, so I am going to wait until we have the
nsGfxListControlFrame working.
Assignee | ||
Comment 3•25 years ago
|
||
GfxListbox probably won't be done until M14, so moving this to M14
Assignee | ||
Updated•25 years ago
|
Target Milestone: M13 → M14
Assignee | ||
Comment 4•25 years ago
|
||
changing to M14
Assignee | ||
Comment 6•25 years ago
|
||
This is fixed for GfxList and I am closing it out now.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•24 years ago
|
||
Reopening because this was fixed for just GfxList and now needs to be fixed for
for non Gfx Listbox
Assignee | ||
Comment 9•24 years ago
|
||
fixed
Status: REOPENED → RESOLVED
Closed: 25 years ago → 24 years ago
Resolution: --- → FIXED
Comment 10•24 years ago
|
||
Anyone have suggestions for how to test this?
Whiteboard: [nsbeta3+] → [nsbeta3+]; requesting engineer feedback-ckritzer;
Reporter | ||
Comment 11•24 years ago
|
||
It's a code-level fix. Whoever reviewed it for Rod should verify.
Assignee | ||
Comment 12•24 years ago
|
||
there isn't anyway to test it,
Comment 13•24 years ago
|
||
Fair enough. Thanks Buster, Rods for your comments.
Based on engineering comments, marking VERIFIED FIXED on:
- LinuxRH62 2000-09-13-08-M18 Commercial
- Win98 2000-09-13-08-M18 Mozilla
- MacOS86 2000-09-13-04-M18 Commercial
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•