Closed Bug 21901 Opened 25 years ago Closed 25 years ago

[UI] dialogs don't have a title

Categories

(SeaMonkey :: MailNews: Message Display, defect, P3)

x86
All
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: sspitzer, Assigned: davidm)

Details

on linux, the title is "mozilla-bin", the name of the application.
Target Milestone: M16
Is this davidm's bug? Not a beta stopper for mail/news
Status: NEW → ASSIGNED
I got the fix in my tree. but yes, it was probably a davidm bug. I fixed it late one night, when I was too tired to fix other bugs, but too awake to go home.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
reopen. Generating of default titles should not be done in the nsCommonDialogs class. It should be done in nsWebShellWindow or anyone else that choses to use the nsCommonDialogs to implement the nsIPrompt Interface.
Assignee: sspitzer → davidm
Status: REOPENED → NEW
reassign
Resolution: FIXED → ---
Clearing FIXED resolution due to reopen.
They do have a title if put up by the single-signon module. And all apps should use the single-signon method rather than puttingup their own password dialog. So should we mark this bug as closed?
I agree that people should be using SS for password prompts but this encompasses a bit more than that ( JS alerts, confirms, and prompts for one). nsIPrompt should probably be expanded to take a title param so that the DOM can place Javascript in the title, Necko can place the URL,.... . But that is a different bug/issue.
Summary: [UI] password dialogs don't have a title → [UI] dialogs don't have a title
In that case the summary line on this bug report is too restrict. Changing from "password dialogs don't have a title" to "dialogs don't have a title"
Status: NEW → RESOLVED
Closed: 25 years ago25 years ago
Resolution: --- → FIXED
Fix checked in. Nothing to QA. Verified that on at least 1 platform ( mail was broken on some of my other builds) that mail password dialog has a title along with most of the other dialogs.
QA Contact: lchiang → nbaca
Build 2000-03-15-06M15nb1b: NT4 Build 2000-03-13-18M15nb1b: Linux 6.0 Build 2000-03-08-14M15: Mac 8.5.1 Verified Fixed. Dialogs appear to have titles. Specifically, I logged into my mail account and the title of the dialog is "Password". Also entered a Master Password and its dialog stated "Password". (Seperate issue: The names of these dialogs should probably be different but will wait until the spec for Master Passwords is finished, after beta1).
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.