User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6a) Gecko/20031024 Firebird/0.7+ Build Identifier: Mozilla Thunderbird 0.4a (20031026) Currently if "mailnews.headers.showUserAgent" is set to true, an X-Mailer: and User-Agent: header are displayed on the message view, both for email and newsgroups. However, some nntp clients use the x-newsreader header as their UserAgent. It would be nice if "mailnews.headers.showUserAgent" also showed the X-NewsReader: header if it exists. Reproducible: Always Steps to Reproduce: 1. Load a Newsgroup message with an X-Newsreader header. Actual Results: No UserAgent was displayed Expected Results: Preferably, displayed the UserAgent as being the value of X-Newsreader.

I can't test this as I've never managed to get Mozilla (Thunderbird) to compile correctly... but it might work. <crosses fingers>

Comment on attachment 134316 [details] [diff] [review] Possible Patch This won't work unless you also patch http://lxr.mozilla.org/seamonkey/source/mailnews/mime/emitters/src/nsMimeHtmlEm itter.cpp#228

I wondered that - I'll do that if I can get mozilla to build and am able to test it.

This patch actually works when I compile it.

Comment on attachment 134347 [details] [diff] [review] Patch [Checkin: See comment 9] Assuming this compiles... So, which newsreaders set x-newsreader?

The ones I've seen are Outlook Express 6 and Forte Agent although there may be more.

This provides the x-newsreader as user-agent on Thunderbird. This needs at least part of the previous patch as well.

Since I can't recall having submitted patches to the Mozilla Seamonkey part of the tree before, how do I go about getting this patch advanced through the stages before checkin?

Comment on attachment 134347 [details] [diff] [review] Patch [Checkin: See comment 9] mozilla/mailnews/mime/emitters/src/nsMimeHtmlEmitter.cpp 1.79 mozilla/mailnews/base/resources/content/msgHdrViewOverlay.js 1.127

This is an automated message, with ID "auto-resolve01". This bug has had no comments for a long time. Statistically, we have found that bug reports that have not been confirmed by a second user after three months are highly unlikely to be the source of a fix to the code. While your input is very important to us, our resources are limited and so we are asking for your help in focussing our efforts. If you can still reproduce this problem in the latest version of the product (see below for how to obtain a copy) or, for feature requests, if it's not present in the latest version and you still believe we should implement it, please visit the URL of this bug (given at the top of this mail) and add a comment to that effect, giving more reproduction information if you have it. If it is not a problem any longer, you need take no action. If this bug is not changed in any way in the next two weeks, it will be automatically resolved. Thank you for your help in this matter. The latest beta releases can be obtained from: Firefox: http://www.mozilla.org/projects/firefox/ Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html Seamonkey: http://www.mozilla.org/projects/seamonkey/

Thunderbird part of this change... its already been implemented on the suite applications, but the thunderbird part got missed.

Comment on attachment 197569 [details] [diff] [review] Thunderbird Part (v2) Hmm, apparently the review flag went AWOL when I moved this bug to Thunderbird.

Was this patch ever checked in?

No.

Comment on attachment 347430 [details] [diff] [review] unbitrotted patch Thx, Gary! >+ if (lowerCaseHeaderName == "x-mailer" || >+ lowerCaseHeaderName == "x-newsreader" || >+ lowerCaseHeaderName == "x-mimeole") > lowerCaseHeaderName = "user-agent"; Please align the condition as if (lowerCaseHeaderName == "x-mailer" || lowerCaseHeaderName == "x-newsreader" || lowerCaseHeaderName == "x-mimeole") lowerCaseHeaderName = "user-agent";

Formatting changed as per previous comment. Bringing over review+.

Magnus, could you please check this in as well?

Comment on attachment 347477 [details] [diff] [review] unbitrotted patch v2 >- // for consistancy sake, let's force all header names to be lower case so >+ // For consistency's sake, let us force all header names to be lower (Is the |'s| actually wanted ?) >+ // If we have an x-mailer, x-newsreader, or x-mimeole string, >+ // put it in the user-agent slot which we know how to handle already. >+ if (lowerCaseHeaderName == "x-mailer" || >+ lowerCaseHeaderName == "x-newsreader" || >+ lowerCaseHeaderName == "x-mimeole") (This could use a regexp, like |/^x-...$/.test(lowerCaseHeaderName)|.

(In reply to comment #19) > (From update of attachment 347477 [details] [diff] [review]) > >- // for consistancy sake, let's force all header names to be lower case so > >+ // For consistency's sake, let us force all header names to be lower > > (Is the |'s| actually wanted ?) For correct language, yes. > > >+ // If we have an x-mailer, x-newsreader, or x-mimeole string, > >+ // put it in the user-agent slot which we know how to handle already. > >+ if (lowerCaseHeaderName == "x-mailer" || > >+ lowerCaseHeaderName == "x-newsreader" || > >+ lowerCaseHeaderName == "x-mimeole") > > (This could use a regexp, like |/^x-...$/.test(lowerCaseHeaderName)|. Not sure.. Magnus, thoughts?

You can use if (/^x-(mailer|mimeole|newsreader)$/.test(lowerCaseHeaderName)) ... if you want.

Re-requesting review to ensure this tastes good for TB.

Comment on attachment 347691 [details] [diff] [review] unbitrotted patch v3 - TB [Checkin: Comment 24] Looks good, thx! Will check it in shortly.

changeset: 1080:a96e4d724c04 http://hg.mozilla.org/comm-central/rev/a96e4d724c04 ->FIXED (for thunderbird, seamonkey needs it's own bug)

(In reply to comment #24) > changeset: 1080:a96e4d724c04 > http://hg.mozilla.org/comm-central/rev/a96e4d724c04 > > ->FIXED (for thunderbird, seamonkey needs it's own bug) SeaNonkey was already fixed, see comment 9 or comment 11 ;-)

(In reply to comment #25) > SeaNonkey was already fixed, see comment 9 or comment 11 ;-) Exact. Though I just filed bug 467192 to sync' to the new code...