The following file copied nsIModule. Please use the macro NS_IMPL_NSGETMODULE instead. D:\cmonkey\mozilla\mailnews\base\build\nsMsgFactory.cpp(240): D:\cmonkey\mozilla\mailnews\db\msgdb\build\nsMsgDBFactory.cpp(107): D:\cmonkey\mozilla\mailnews\imap\build\nsImapFactory.cpp(131): D:\cmonkey\mozilla\mailnews\import\eudora\src\nsEudoraFactory.cpp(152): D:\cmonkey\mozilla\mailnews\import\oexpress\nsOEFactory.cpp(139): D:\cmonkey\mozilla\mailnews\import\outlook\src\nsOutlookFactory.cpp(139): D:\cmonkey\mozilla\mailnews\import\src\nsImportFactory.cpp(135): D:\cmonkey\mozilla\mailnews\local\build\nsMsgLocalFactory.cpp(141): D:\cmonkey\mozilla\mailnews\mime\build\nsMimeModule.cpp(116):

Not sure why dougt assigned to me. I'm flinging them in alecf's direction.

sigh. Yeah, I'll take this, but I wouldn't mind some help. Adding mscott, putterman, tonyr, and rhp to the CC (they actually own the respective modules)

sigh. Yeah, I'll take this, but I wouldn't mind some help. Adding mscott, putterman, tonyr, and rhp to the CC (they actually own the respective modules)

I'll fix nsImportFactory but I don't think nsEudora*, nsOE*, nsOutlook*, and nsTextFactory can be converted. Each of those modules puts some data into the mozilla registry when the component is registered. I don't see a way to do that without having the component implement it's own nsIModule since it needs to execute some extra code in nsIModule::RegisterSelf

For the modules that does percomponent writing to registry at install time, I need to implement something. I am hoping to do a per component registration and unregister proc in the structure.

No user-visible downside to this, so pushing to M16.

The reg/unreg hook for generic modules is checked in. So this bug should have not dependencies blocking it. I agree. No user downside if we dont fix this. Upside would be reduced footprint.

mailnews/base/build is done.

*spam* changing qa contact from nobody@mozilla.org to me (BlakeR1234@aol.com) on 121 open or resolved (but not verified) bugs. sorry for the spam everybody, but most of these bugs would just remain dormant and not checked by QA otherwise. I'm not sure how so many bugs have nobody as their QA contact, but I suspect this is the fault of some sort of bugzilla corruption that happened at some point (most of these bugs are in the 20000-26000 range, and I don't see where in the activity log that QA contact explicitly changed to nobody@mozilla.org) Anyways, sorry again for spam. If you really get annoyed, I'm usually available in #mozilla on IRC for torture.

reassign to mscott

Is this even still an issue?

sorry for the spam. making bugzilla reflect reality as I'm not working on these bugs. filter on FOOBARCHEESE to remove these in bulk.

I've just had a look at all the still-existing files - they all use NS_IMPL_NSGETMODULE and follow the general standard of the rest of the tree, therefore I believe this bug is WFM.