Need pref panel for irc/chatzilla.

spam: added self to cc list.

making this the general tracking bug for prefs

mass marking chatzilla bugs future

...I can't do anything here unless I know what functionality the pref pane needs...

Maybe we need to come up w/ a basic list: * Script/Event editor * Network prefs - Rename network - Servers prefs \ Retry and timeout numbers \ Rename server \ Set 3 nicks \ ident \ modes (+i->invisible, +w->wallops, +...) \ Rejoin channels on reconnect - Channel settings \ Autorejoin on kick * DCC prefs - AutoAccept|Prompt on Receive|AutoDeny \ Wait until you have finished typing before prompting for incoming DCCs - Default location - Port range - Block Size * Logging - Server - Channel - Query - DCC - Strip Color tabs - Timestamp * Appearance [For each of the different possible types of events] - Colors - Fonts - Styles *Userlists - Ignore list - Notify list This is of course borrowed (poorly) from another irc client and is not complete.

Is that just a random list of desired features and prefs, or do we actually support those in the backend?

I'd prefer not to see widgets in the pref pane for prefs that don't exist yet. The comment at the top of http://lxr.mozilla.org/mozilla/source/extensions/irc/xul/content/readprefs.js describes what prefs are currently implemented, but .style.default should be left out as I'm not really supporting it anymore. I set up a minimal pref pane a while back and never checked it in, I'll attach a diff to this bug to help get you started.

Robert: OK, thanks. Reassigning to me, but this is low priority on my list, so if anyone else wants to step in...

CCing mpt to see if he has any thoughts on this.

* nickname, username, and desc belong in the Identity panel, which belongs in the General branch, which doesn't yet exist. * network and channel belong in a Room Directory (analagous to the bookmarks or address books). Can someone explain what the various extensions.irc.style.* prefs do?

*MASS SPAM* Changing QA contact on all open or unverified ChatZilla bugs to me, David Krause, as I am now the QA contact for this component.

Putting rginda in the CC list since I bumped him from this bug.

I don't have any time for this right now. Sorry. Punting back to nobody so another lucky owner can find this, and wishing bugs could just simply not be assigned to anyone.

*** Bug 37542 has been marked as a duplicate of this bug. ***

*** Bug 37542 has been marked as a duplicate of this bug. ***

*** Bug 37542 has been marked as a duplicate of this bug. ***

I might give this a spin... I'll take a look at the attachments later and see if I can handle it :)

Hmmm... it ought to be fairly simple to create a pref pane for ChatZilla, assuming we can decide *what* we want on it... ;) (/me remembers the arguments over bug 17199) My initial guess would be to definately have the user name, description and nickname prefs, and it would probably be a good idea to have the auto-connect list. (if anyone knows a better place to discuss this, feel free to suggest it)

I suggest the netscape.public.mozilla.prefs newsgroup... But using the bug works for me...

netscape.public.mozilla.rt-messaging would be most appropriate.

I've posted a message to netscape.public.mozilla.rt-messaging, so we can discusse the pref pane there.

Remove myself from QA of 33 open Chatzilla bugs and change to default QA contact, since I have no way to verify these easily. Still no working Mozilla on my primary platform and it doesn't look like it will happen anytime soon. :(

Alright, I'm gonna have a go at this. Currently got four pref pages in the plan: + ChatZilla + Startup + Text & Display + Sound The ChatZilla (main) page has prefs: Nickname, username, description, aggressive notify, focus new tabs, and stalk words. The Startup page has the two startup lists, scripts and URLs; with add/delete/up/down buttons for both lists. The Text & Display page has most of the munger options, plus collapse consecutive messages, and copy important messages. The Sound page has the three sound events; private message in current view, message in /query view, and sound for stalk words.

James, Just added my vote to the list. Your outline sounds good to me, but you should probably drop by irc://irc.mozilla.org/#chatzilla and run it by rginda. Keep in touch. I for one would love to know how you are progressing.

I hope this patch is useable... I couldn't find any way do diff the new files with cvs (I have no cvs write access). This attachement contains a cvs diff -c of the two existing files, plus a manual diff -c against an empty file for the rest (I added the lines of equals to seperate these diffs).

I started making my own pref panels for ChatZilla before rginda helped me find this bug. I've made three panels: -the root one currently has nick/id/desc, various /stalk settings, startup scripts and networks. -Appearance: all the munger settings (with some styles and fancy XUL to visually represent them), stylesheet, and collapsing consecutive messages. -Interface: "[x] open new tabs for /msg [x] only if less than [12] tabs are open", and scrollback buffer sizes. These are all settings taken from the top of readprefs.js . I have most of those covered now. I can describe all the prefs I've got covered so far, and how, on request. The point of this post is, are you interested in what I've done? You're welcome to it if you want it.

By all means, attach your patch to this bug report. At the very least, it's a start.

Here are the panels, as well as the en-US dtd for them. I'll attach a screenshot in a moment.

And here's the shot. I'm proudest of the the munger settings on the middle panel. You might cringe a bit at the XUL there though. Checkboxes wouldn't keep the actual checkbox graphic when I put child elements within, so I had to re-add it manually. For the prefs that take semicolon-separated lists (like the /stalk words), I was planning on eventually making them into a listbox, which I think looks a bit cleaner and is a bit less error-prone (the actual pref would be in a collapsed textbox). I hadn't gotten that far before I learned I wasn't alone on this thing. (: There it is, I hope someone can find it useful. BTW, I'm willing to keep working on this if you need the help.

Please don't let my lack of comments slow anyone down :) I'd really like to see this get in. James, your patch looks pretty good. Chatzilla JavaScript style is 4 spaces per indent level, and no line over 80 columns. Chatzilla XUL is normally two spaces per indent level. Long lines are more easily forgiven in XUL, but don't overdo it :) I really like the looks of David's munger panel, regardless of what the XUL looks like :) Perhaps we could observe changes in extensions.irc.*, and just call readIRCPrefs () when something changes.

Same as attachement 99804, except source re-formatted to 2/4 spaces, 80 characters.

How about changing the Preferences... menu item in cz to point to the new panel? The line to be modified is http://lxr.mozilla.org/seamonkey/source/extensions/irc/xul/content/menus.xul#204 Also, James, on line seven of prefsOverlay.xul "chatzillaItem" to "chatzilla"? Yeah, I know it is one innane little nit, and and there is probably some very good reason for chatzillaItem that I am overlooking. This gives some very nice functionality.

Ignore my nitpicking, please. Looks like xxxItem is prefered. How about bug 116588, bug 109814, bug 133184, bug 27807, and bug 119746? Is there any way this should be refactored to be extensible, or should we get it checked in and then rip it to pieces? I'm not saying that these should be fixed, just that this might be the time to consider it. How about a setting for Motif?

I thik there already is UI for motifs in this patch...Stylesheet, under Appearance. My vote, FWIW, is to get this in and *then* worry about those other bugs. Especially since some of those other bugs listed seem to require backend functionality that doesn't exist yet, and waiting for that to be implemented could delay this indefinitely.

I agree. Get the main functionality in and then we can work on the other bugs. Thanks for the great work!

Garth, the patch I tried was James'. James' lacks a few settings which David's has, and vice versa.

rginda: Back in comment 7, you said the pref "extensions.irc.style.default" is not really being supported any more, yet it is (as far as I can tell) how ChatZilla stores which Motif to use. Is it safe for me to use this pref in my preference pages, or is there some other way I should use to change the Motif being used?

Comment 7 (from August of 2000, no less) is out of date. You are correct, "extensions.irc.style.default" is used to store the currnt motif these days.

Split prefs up a bit differently - now there's 5 sub-panes. Added scrollback options, auto PM tab creation, and the Motif option.

Comment on attachment 105910 [details] Updated patch, with more prefs covered. you don't need to attach a file again, simply click edit, uncheck the [ ] patch and change the mime type.

Whoop, sorry 'bout that. Also, if you want to test my pref pages, (closing Mozilla first) you need to put the files in the zip into chrome/chatzilla.jar (keeping paths), and open chrome/overlayinfo/communicator/content/overlays.rdf (from where you installed Mozilla) and add the line <RDF:li>chrome://chatzilla/content/prefsOverlay.xul</RDF:li> in the section starting with the line <RDF:Seq about="chrome://communicator/content/pref/preftree.xul"> Then start Mozilla.

build system changes to add the new files to chatzilla.jar, and register the pref overlay.

James, this is great stuff, thanks for taking the lead on this. A few comments... 1. The "Copy important messages" checkbox is disabled, I can't change it. 2. Autoload scripts *have* to be local files, they must be file:/// urls to work. The help text from the add window makes it sound like any web address will work. I think we should present a file picker widget from the "add..." button, like in the Sound tab. 3. In the autoconnect tab, "Add..." should offer to add private message tabs too. Also, it would be nice to have UI for the ",needpass" and ",needkey" flags. 4. In the Appearance tab, it might be nice to have buttons for the faces motifs too. 5. In the Sound tab, the caption for "Sound on simple message to you" should actually be something like "Sound on new Private Message tab". The "Sound on Private Message to you" caption could be changed to "Sound on existing Private Message tab". 6. I think we need to register a pref callback before we can check this in, so that users can change prefs while running chatzilla. See http://lxr.mozilla.org/mozilla/source/modules/libpref/public/nsIPrefBranchInternal.idl 7. You've got some english hardcoded in the .js files, "Scripts" and "URLs", for example. Please move them to chatzilla.properties instead. Please bring the code in line with http://www.hacksrus.com/~ginda/chatzilla/pedant.html. Specifically the points on bracing, double quotes, license and modelines, and else after return.

> 1. The "Copy important messages" checkbox is disabled, I can't change it. That's because of the pref bug on that particular pref - I'm not (at the moment) going to attempt to fix the pref with this bug, so I'm leaving it in to show we /could/ do the pref, just not quite yet. > 2. Autoload scripts *have* to be local files, they must be file:/// urls to > work. The help text from the add window makes it sound like any web address > will work. I think we should present a file picker widget from the "add..." > button, like in the Sound tab. Ok, I'll sort that out (I was just guessing from the fact is used URLs). > 3. In the autoconnect tab, "Add..." should offer to add private message tabs > too. Also, it would be nice to have UI for the ",needpass" and ",needkey" > flags. The needpass/needkey ones yeah, but the PM option is a little dubious right now - I've had ChatZilla die on starting if I have a PM startup URL on occasion. I'll add it, but I think something else might need fixing too. :) > 4. In the Appearance tab, it might be nice to have buttons for the faces > motifs too. Sure thing, just gotta find the chrome URIs. > 5. In the Sound tab, the caption for "Sound on simple message to you" should > actually be something like "Sound on new Private Message tab". The "Sound on > Private Message to you" caption could be changed to "Sound on existing Private > Message tab". OK, sure thing. > 6. I think we need to register a pref callback before we can check this in, so > that users can change prefs while running chatzilla. See > http://lxr.mozilla.org/mozilla/source/modules/libpref/public/nsIPrefBranchInternal.idl I was kinda trying to avoid this one. ;) (I'll look into it at some point) > 7. You've got some english hardcoded in the .js files, "Scripts" and "URLs", > for example. Please move them to chatzilla.properties instead. Hmm... those two bits are refering to the IDs given to elements in the XUL (and so are exempt from i18n); I don't see what advantages there are to putting them in the .properties file.

I admit I haven't looked at the most recent changes. But you might want to add/leave space somewhere for another textbox, for "BugZilla link URL" (or something similar), in case bug 116588 gets fixed. (rginda: Do I get marks for subtlety? (: )

When the patch gets checked into the cz tree we should remove File->Options menu because it will no longer be needed. also it seems like jame's pref panel has fewer options for the munger than david's. I also personally like the looks of that part of david's panel better than the other one.

I've got the private message urls fixed, and I'm working on redoing readprefs.js with a pref observer. The problem with copy important messages should be fixed too. I'm also adding a pref for the notify list, and I'll address bug 116588 too. There are no chrome URIs for the faces motif, the http URIs are: http://www.hacksrus.com/~ginda/chatzilla/motifs/output-default-faces.css http://www.hacksrus.com/~ginda/chatzilla/motifs/output-light-faces.css http://www.hacksrus.com/~ginda/chatzilla/motifs/output-dark-faces.css One other issue I noticed is that the "Text Style" *can't* come from a file: url, because of a bug in mozilla. So the "Choose File..." option shouldn't bring up a file picker.

This adds a pref listener, so that you can change prefs through the panel and see the updates in a running instance of chatzilla. It's kind of a hack job, but cleaner than what was there before. Given my time restraints, its probably the best we can hope for, for now. I added a new pref for the bugzilla url pattern, "bugURL", whose default value is "http://bugzilla.mozilla.org/show_bug.cgi?id=%s". Parsing of ,isnick irc: URLs works reliably now. I changed the accelerator key for "delete view" from ctl+x to ctl+z. (bug 122782.)

Ok, I'm just finishing off the last few Internationalisation (I18n), Localisation (L10n) and Accessibility things for the pref pages, and I've made the CSS style and sound selection a bit nicer (IMO). You can look at the screen shots of the new pages at http://www.warwickcompsoc.co.uk/~silver/mozilla/chatzilla/prefpages if you can't wait. News stuff: - nickname completion pref - copy important messages now works - auto-connect items now support needkey, needpass and isnick modifiers - Bugzilla bug URL pref - ability to preview the selected CSS style Robert Ginda: what's your preferred way to get the new files? ZIP attachement like last time ok?

*** Bug 187592 has been marked as a duplicate of this bug. ***

I don't know if it's a panel or a Phoenix related "problem", but when I open Chatzilla's preferences, more preferences are shown (I'm speaking about the category list) than Phoenix originally shows. Win98 SE + Phoenix 0.5 + Chatzilla 0.8.12-pre6 installed via XPI

Ok, this is the update as mentioned in comment #53. Attachement contains all the files, with chatzilla.jar paths.

Troodon: I think the problem lies with the fact that Phoenix has a different chrome URL for the pref page (Mozilla's is chrome://communicator/content/pref/pref.xul, Phoenix's is chrome://browser/content/pref/pref.xul), and because ChatZilla is, as far as I know, only designed to work with Mozilla, it opens the Mozilla preferences (by opening a window with the mentioned URL) which are still in Phoenix, though may not be in later releases).

From http://www.mozilla.org/projects/rt-messaging/chatzilla/ "You must be using a Mozilla based browser to run ChatZilla." It says Mozilla based, not Mozilla :P. Anyway, it's a minor problem. Thanks!

checked in

The CZ menuitem still opens Nav prefs :-(

I suppose you are aware of the fact that the main pref page does not display in 2003012308 on Win2k? (at least here) (Yes that one has the stringbundle fix in it already.)

No... and it's all working fine here on 20030121. And the 23rd builds have a broken installer right now, so I can't check it. Could you give us a few more details? Specifically, what actually happens on the page? Does it just get cut off? Some XML parsing error?

Re comment #63: Well, I just tried with a new profile, but still nothing: When you select the chatzilla main preferences panel (not startup, interface or something), the panel itself (on the right) will just stay empty (in the lighter color that is also behind the preftree to the left). There is *no* XUL error shown and no error on the JavaScript console. With an older build from 1-2 days ago it worked. First I thought that stringbundle regression was the cause but that is fixed in my build. Maybe somebody with build 2003012308 or similar should try verify this. (the nightly zips work well - if not downloaded using a build between 17th and yesterday which contains that network data corruption)

James, I found the problem (it IS a problem) and filed bug 190395. I already have a fix and requested r= and approval.

checked in

James, did you intentionally use "Appearance" as title for every one of your new pref panels?? Your screenshot shows it differently: there the title at the top of every window is identical to the name in the tree to the right (e.g. "Chatzilla", "Interface",...). But now every panel has headertitle="&window.title;" (from pref-irc.dtd) for title. In pref-irc.dtd unfortunately window.title is defined *various times*! (as "Chatzilla", "Interface",...) Only the first definition is now taken for all prefs panels - ant that is the one in line 1 which makes the panels all be titled "Appearance". I have no time to post a fix within 24 hours. Maybe afterwards...

Oops, I think that was Robert Ginda putting all the .dtd files into one file. They (in my patch) used seperate .dtd files for each page, so they'd all use &window.title; - which of course doesn't work if they all use one .dtd file. :)

Somebody filed bug 190777 on the problem in comment 67, so this bug can and should better rest in peace.