Closed
Bug 234665
Opened 21 years ago
Closed 16 years ago
Delete button should re-text to "Undelete" when a deleted message is selected
Categories
(Thunderbird :: Mail Window Front End, enhancement)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0a3
People
(Reporter: cross, Assigned: mkmelin)
References
Details
Attachments
(1 file)
(deleted),
patch
|
philor
:
review+
|
Details | Diff | Splinter Review |
User-Agent:
Build Identifier: Thunderbird/0.5
When a deleted message is selected, the text on the "Delete" button in the top
button-bar should change to "Undelete", much the same way the "Junk" text
changes to "Not Junk" when a junk message is selected.
Reproducible: Always
Steps to Reproduce:
1. Select a deleted message
Actual Results:
No change in the text of the "Delete" button
Expected Results:
Should've changed the text to "Undelete", as that's the result of clicking the
button in this condition.
I think the reason why it's not set to "Undelete" is because the "Delete" button
is still needed to permanently delete a message from the Trash.
*** Bug 232859 has been marked as a duplicate of this bug. ***
Comment 3•19 years ago
|
||
(In reply to comment #0)
> Expected Results:
> Should've changed the text to "Undelete", as that's the result of clicking the
> button in this condition.
This only happens in the far less frequent case where someone's selected that
pressing delete only marks a message as deleted instead of having it moved to
the trash bin.
To fix this right, we'd need to only change the text of the function when that
mode is on, and IMO, it's not worth the effort/bother. Strongly suggest WONTFIX.
Updated•19 years ago
|
Severity: normal → enhancement
Summary: RFE: Delete button should re-text to "Undelete" when a deleted message is selected → Delete button should re-text to "Undelete" when a deleted message is selected
Version: unspecified → Trunk
Updated•18 years ago
|
QA Contact: front-end
also in bug 207485, but for moz app suite (sm), very old also ..
So it's been a while now, some versions already out, is this interesting anymore? or just won't fix? as in comment 3?
Updated•16 years ago
|
Assignee: mscott → nobody
Assignee | ||
Comment 5•16 years ago
|
||
Well I don't see why we wouldn't do it. The menu items under Edit already rephrase properly. I don't think it's very unusual (though for sure a minority) for people to use the imap mark as deleted model. I do, mostly.
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #336252 -
Flags: review?(philringnalda)
Updated•16 years ago
|
Attachment #336252 -
Flags: review?(philringnalda) → review+
Comment 6•16 years ago
|
||
Comment on attachment 336252 [details] [diff] [review]
proposed fix
Yeesh. Given all the code we already have to change the menu, and make the Delete key the Undelete key, this makes perfect sense. I just wish we didn't have any of it...
Assignee | ||
Comment 7•16 years ago
|
||
changeset: 331:ba1576dfde33
http://hg.mozilla.org/comm-central/rev/ba1576dfde33
->FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•