Closed Bug 23571 Opened 25 years ago Closed 24 years ago

onchange= not working for html:input type="checkbox"

Categories

(Core :: DOM: UI Events & Focus Handling, defect, P3)

defect

Tracking

()

VERIFIED FIXED

People

(Reporter: alecf, Assigned: pollmann)

Details

(Whiteboard: [nsbeta2+] fix in hand)

Attachments

(1 file)

I have a checkbox in the mail Account Wizard that I use to enable/disable a nearby field when the value is changed. Unfortunately, the onchange= handler never fires....onclick= seems to work, but then it only works for changing it with the mouse (and really breaks keyboard navigation!)
adding vidur because this is DOM related I think
This looks like a DUP of bug 22472 "[DOGFOOD] onchange= doesn't appear to work for html:input", NEW
Assignee: joki → pollmann
I think it may be different actually. I just fixed 22472 but that was text only. Sending to pollmann for more input.
I just backed out my change from last night, which should fix this bug, will have to wait for my build to finish to verify.
Whiteboard: [MAKINGTEST] noid@pcisys.net
Whiteboard: [MAKINGTEST] noid@pcisys.net
Attached file Test case (deleted) —
That didn't fix the bug. :( Well, I'll look at it at the next opportunity.
Status: NEW → ASSIGNED
Target Milestone: M15
Moving to M16
Target Milestone: M15 → M16
Rescheduling
Target Milestone: M16 → M21
This bug has been marked "future" because the original netscape engineer working on this is over-burdened. If you feel this is an error, that you or another known resource will be working on this bug,or if it blocks your work in some way -- please attach your concern to the bug for reconsideration.
Target Milestone: M21 → Future
This is pretty basic, "Netscape 3.0" style DOM0 functionality. Using checkboxes to enable/disable other parts of a form is something that is used quite a lot. I would like to see this fixed (you giving my opinion here...)
This is still broken. I agree, it's serious - thanks for pointing this out! I'll pull this back in and try to work out a fix.
Target Milestone: Future → M17
OS: Linux → All
Hardware: PC → All
I have a simple fix for this in my tree.
Whiteboard: fix in hand
Thanks!
Nominating for beta2. This is part of the HTML spec. It may break websites to not send out a change event when a checkbox is clicked on. Fixing this bug will fix these websites. I have a fix in my tree which is small and safe - the change is to create and dispatch a change event when we are updating the 'checked' status of the checkbox or radio inputs.
one example of this is bugzilla with unconfirmed bugs - if you go to check "And confirm this bug" with one of the bug actions at the bottom of the bug, the appropriate radio button will not be automatically selected.
Keywords: nsbeta2
Putting on [nsbeta2+] radar for beta2 fix.
Whiteboard: fix in hand → [nsbeta2+] fix in hand
Fix is in. This change will fire an onchange event for checkboxes and radio changes invoked via the mouse, the keyboard, or javascript. Thanks Harish for three (count them) reviews. :) To verify, view the above Test case. Clicking on the checkboxes with a mouse or using the keyboard to tab around and pressing Space or Enter should have the effect of enabling and disabling the Submit button. Thanks!
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Verified 2000-07-17-13-M17 : Linux 2000-07-17-09-M17 : WinNT & Win98 2000-07-13-08-M17 : Mac
Status: RESOLVED → VERIFIED
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: